Skip to content

Conversation

@timbellay
Copy link
Contributor

Previous Behavior

  • N/A, adding some cleanup items for Fluent V9

New Behavior

  • Collapsed app state into single state with reducer. Fixed infinite state updating bug.
  • Simplified flow of app using the left nav and steps for user to generate palette.
  • Updated sticker sheet to show missing v9 components
  • Created a test object and a test system for future tests and clarity of test results.
  • Reduced contrast tests to handle the main two tests only: colorBrandForeground1: ['colorNeutralBackground1', 4.5] and colorBrandForeground2: ['colorBrandBackground2', 4.5] for simplicity.
  • Added contrast ratios to dropdown in the token selection menu of failed tests so users can know the effect of changing a token value on the test.
  • Change curve snapping points from [0, 50, 100] to [start, middle, end] based on Arman's spec and hard coded this in hueToSnappingPointsMap.
  • Use brand[110] instead of brand[100] and brand[120] instead of brand[110] for dark theming per guidelines
  • Minor GUI improvements

Related Issue(s)

timbellay and others added 30 commits March 21, 2023 11:38
@TristanWatanabe
Copy link
Member

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TristanWatanabe
Copy link
Member

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@sopranopillow sopranopillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly minor comments, I would say the sticker ones are needed since those are exposed to the user. The Designer looks great!!!

@sopranopillow
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@sopranopillow sopranopillow enabled auto-merge (squash) May 19, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants