Skip to content

fix(react-popover): Stop propagation when closing the PopoverSurface with Escape #27832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 5 commits into from
May 18, 2023
Merged

fix(react-popover): Stop propagation when closing the PopoverSurface with Escape #27832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44ecc0e
fix: stop propagation when closing the popover surface to avoid closi…
sopranopillow May 12, 2023
07bbbba
change file
sopranopillow May 12, 2023
6a7d1af
requested changes
sopranopillow May 17, 2023
1d0fb0e
update change file
sopranopillow May 17, 2023
001e09d
Merge branch 'master' of https://www.github.com/microsoft/fluentui in…
sopranopillow May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-popover-cd0f51c6-92c0-4de4-917e-df1a53233d3b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: preventDefault when closing the popover surface to avoid closing parent dialogs.",
"packageName": "@fluentui/react-popover",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-popover/src/components/PopoverSurface/usePopoverSurface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export const usePopoverSurface_unstable = (
// only close if the event happened inside the current popover
// If using a stack of inline popovers, the user should call `stopPropagation` to avoid dismissing the entire stack
if (e.key === 'Escape' && contentRef.current?.contains(e.target as HTMLDivElement)) {
e.preventDefault();
setOpen(e, false);
}

Expand Down