Skip to content

bugfix(react-tree): fix VisibleFlatTreeItemGenerator omitting visible items #27802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
May 10, 2023
Merged

bugfix(react-tree): fix VisibleFlatTreeItemGenerator omitting visible items #27802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tree-e91902ae-b031-47c0-99be-2f7450c3f3f7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "bugfix: fix VisibleFlatTreeItemGenerator omitting visible items",
"packageName": "@fluentui/react-tree",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/react-components/react-tree/src/utils/createFlatTreeItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ export function* VisibleFlatTreeItemGenerator<Props extends FlatTreeItemProps<un
) {
for (let index = 0, visibleIndex = 0; index < flatTreeItems.size; index++) {
const item = flatTreeItems.getByIndex(index) as FlatTreeItem<Props>;
const parent = item.parentValue ? flatTreeItems.get(item.parentValue) ?? flatTreeItems.root : flatTreeItems.root;
if (isItemVisible(item, openItems, flatTreeItems)) {
item.index = visibleIndex++;
yield item;
} else {
index += parent.childrenSize - 1 + item.childrenSize;
// Jump the amount of children the current item has, since those items will also be hidden
index += item.childrenSize;
}
}
}
Expand Down