fix: ToolbarToggleButton should not follow Toolbar size #27797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the Toolbar size was being pased to the ToggleButton
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f7435a:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 27f252e27361df75a94c5bc5b09fc0097fefd969 (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 17 | 16 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 732 | 705 | 5000 | |
| Button | mount | 399 | 403 | 5000 | |
| Field | mount | 1249 | 1210 | 5000 | |
| FluentProvider | mount | 797 | 792 | 5000 | |
| FluentProviderWithTheme | mount | 112 | 116 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 99 | 101 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 110 | 109 | 10 | |
| InfoButton | mount | 17 | 16 | 5000 | Possible regression |
| MakeStyles | mount | 1158 | 1167 | 50000 | |
| Persona | mount | 1937 | 1881 | 5000 | |
| SpinButton | mount | 1479 | 1487 | 5000 |
fabricteam
reviewed
May 9, 2023
change/@fluentui-react-toolbar-5c2c0e49-70bf-4b6d-b5e0-7a1dc8852ba9.json
Show resolved
Hide resolved
layershifter
approved these changes
May 11, 2023
layershifter
approved these changes
May 11, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
May 12, 2023
* feat/drawer-header: feat: Update existing toasts (microsoft#27827) bugfix: fix horizontal overflow on tree (microsoft#27825) feat: Allow toast options to be configured from the toaster (microsoft#27820) feat: creates TreeItemAside component (microsoft#27701) fix: generate API fix: use composition to build DrawerHeaderTitle Virtualizer: Dynamic scroll view and optimizations (microsoft#27298) bugfix(react-dialog): change DialogTitle default action icon size (microsoft#27815) feat: Implement Toast pause (microsoft#27811) fix: ToolbarToggleButton should not follow Toolbar size (microsoft#27797) feat: defers useControllableState state to initializer method (microsoft#27717) feat: Implement toast dismiss (microsoft#27810)
Collaborator
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the Toolbar size was being pased to the ToggleButton
Before
After
