feat(react-jsx-runtime): implements next steps (option A) #27752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6d0848597a7c07883a93b13f67f6727fd791f3dd (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 690 | 702 | 5000 | |
| Button | mount | 380 | 372 | 5000 | |
| Field | mount | 1272 | 1238 | 5000 | |
| FluentProvider | mount | 907 | 911 | 5000 | |
| FluentProviderWithTheme | mount | 119 | 118 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 103 | 92 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 108 | 103 | 10 | |
| InfoButton | mount | 17 | 20 | 5000 | |
| MakeStyles | mount | 1116 | 1092 | 50000 | |
| Persona | mount | 2035 | 1972 | 5000 | |
| SpinButton | mount | 1546 | 1593 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
reviewed
May 4, 2023
| componentType, | ||
| renderFunction, | ||
| $$typeof: SLOT_COMPONENT_SYMBOL, | ||
| props: Object.assign(props, overrides), |
Member
There was a problem hiding this comment.
As commented on another PR, overrides might be not the best concept (https://github.com/microsoft/fluentui/pull/27753/files#r1184763865) as we can't explain who it should be used over slot.props. And it even cannot be used now for cases with callbacks, for example.
Contributor
Author
|
closing this in favor of #27753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)