Skip to content

Conversation

@khmakoto
Copy link
Member

PR Description:

Cherry-pick of #26637.

Original description: Since component governance is forced, we should disable this step since it will remove all files from the working directory and fail component governance.

@khmakoto khmakoto added the CI label Apr 24, 2023
@khmakoto khmakoto requested a review from a team as a code owner April 24, 2023 17:49
@khmakoto khmakoto self-assigned this Apr 24, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 74ed236:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 24, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ad80b8d31d383cd6d8258f9251dd22b7c3205350 (build)

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v7 Open the Visual Regressions report to inspect the 30 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1343 screenshots unchanged, 0 screenshots with different dimensions and 30 screenshots with visible difference.

unknown 30 screenshots
Image Name Diff(in Pixels) Image Type
Card.Horizontal Card - Example with contents.default.chromium.png 27464 Changed
Card.Horizontal Card - Example with contents.focus.chromium.png 27376 Changed
Card.Horizontal Card - Example with contents.hover.chromium.png 27355 Changed
Card.Vertical Card - Example with contents - Image in middle.default.chromium.png 8094 Changed
Card.Vertical Card - Example with contents - Image in middle.focus.chromium.png 8035 Changed
Card.Vertical Card - Example with contents - Image in middle.hover.chromium.png 8094 Changed
Card.Vertical Card - Example with contents - Image on top.default.chromium.png 277566 Changed
Card.Vertical Card - Example with contents - Image on top.focus.chromium.png 275241 Changed
Card.Vertical Card - Example with contents - Image on top.hover.chromium.png 277514 Changed
Image.Fit- CenterContain, image larger.default.chromium.png 12593 Changed
Image.Fit- CenterContain, image smaller.default.chromium.png 32236 Changed
Image.Fit- CenterContain, image taller.default.chromium.png 18134 Changed
Image.Fit- CenterContain, image wider.default.chromium.png 18134 Changed
Image.Fit- center, image larger.default.chromium.png 11026 Changed
Image.Fit- center, image smaller.default.chromium.png 2008 Changed
Image.Fit- centerCover, image larger.default.chromium.png 17710 Changed
Image.Fit- centerCover, image smaller.default.chromium.png 32236 Changed
Image.Fit- centerCover, image taller.default.chromium.png 24267 Changed
Image.Fit- centerCover, image wider.default.chromium.png 24267 Changed
Image.Fit- contain, image taller.default.chromium.png 1171 Changed
Image.Fit- contain, image wider.default.chromium.png 3471 Changed
Image.Fit- cover, image taller.default.chromium.png 7613 Changed
Image.Fit- cover, image wider.default.chromium.png 7613 Changed
Image.Fit- none, image larger.default.chromium.png 10967 Changed
Image.Fit- none, image smaller.default.chromium.png 2008 Changed
Image.Maximize frame, landscape container.default.chromium.png 4074 Changed
Image.No fit, no w-h.default.chromium.png 84392 Changed
Image.No fit, only width.default.chromium.png 166761 Changed
TeachingBubble.WideIllustration - RTL.default.chromium.png 25170 Changed
TeachingBubble.WideIllustration.default.chromium.png 25234 Changed

@fabricteam
Copy link
Collaborator

Perf Analysis

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
GroupedList mount 1044 1161 2 Possible regression
All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1459 1455 5000
Breadcrumb mount 46053 45835 5000
Checkbox mount 2191 2127 5000
CheckboxBase mount 1889 1876 5000
ChoiceGroup mount 5909 5916 5000
ComboBox mount 1446 1404 1000
CommandBar mount 8674 8686 1000
ContextualMenu mount 15795 15799 1000
DefaultButton mount 1689 1691 5000
DetailsRow mount 4650 4645 5000
DetailsRowFast mount 4663 4618 5000
DetailsRowNoStyles mount 4395 4461 5000
Dialog mount 2812 2858 1000
DocumentCardTitle mount 2383 2429 1000
Dropdown mount 3266 3238 5000
FocusTrapZone mount 2292 2281 5000
FocusZone mount 2324 2373 5000
GroupedList mount 1044 1161 2 Possible regression
GroupedListV2 mount 605 601 2
IconButton mount 2439 2374 5000
Label mount 820 823 5000
Layer mount 2567 2578 5000
Link mount 924 978 5000
MenuButton mount 2089 2076 5000
MessageBar mount 2590 2582 5000
Nav mount 4084 4097 1000
OverflowSet mount 1989 1983 5000
Panel mount 1978 1990 1000
Persona mount 1483 1495 1000
Pivot mount 1995 2019 1000
PrimaryButton mount 1825 1878 5000
Rating mount 9304 9191 5000
SearchBox mount 1881 1901 5000
Shimmer mount 3327 3316 5000
Slider mount 2096 2111 5000
SpinButton mount 5934 5923 5000
Spinner mount 886 915 5000
SplitButton mount 4046 3893 5000
Stack mount 1001 1009 5000
StackWithIntrinsicChildren mount 2346 2394 5000
StackWithTextChildren mount 5845 5774 5000
SwatchColorPicker mount 11854 11767 5000
TagPicker mount 3545 3504 5000
TeachingBubble mount 54225 54369 5000
Text mount 955 937 5000
TextField mount 1939 1964 5000
Toggle mount 1365 1344 5000
button mount 588 580 5000

@khmakoto khmakoto merged commit f21f215 into microsoft:7.0 Apr 24, 2023
@khmakoto khmakoto deleted the removeReallyCleanFromCI branch April 24, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants