Skip to content

fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable #27650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khmakoto merged 2 commits into from
Apr 20, 2023
Merged

fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable #27650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47fd448
fix: ContextualMenuSplitButton always sets aria-checked (does not lea…
khmakoto Apr 20, 2023
dd5e83e
Adding change file.
khmakoto Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-8279ee8e-b6e5-4f7f-b9e7-18a13d31e6cb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable.",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6 changes: 4 additions & 2 deletions ...act/src/components/ContextualMenu/ContextualMenuItemWrapper/ContextualMenuSplitButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
import { ContextualMenuItem } from '../ContextualMenuItem';
import { getSplitButtonVerticalDividerClassNames } from '../ContextualMenu.classNames';
import { KeytipData } from '../../../KeytipData';
import { isItemDisabled, hasSubmenu, getMenuItemAriaRole } from '../../../utilities/contextualMenu/index';
import { getIsChecked, getMenuItemAriaRole, hasSubmenu, isItemDisabled } from '../../../utilities/contextualMenu/index';
import { VerticalDivider } from '../../../Divider';
import { ContextualMenuItemWrapper } from './ContextualMenuItemWrapper';
import type { IContextualMenuItem } from '../ContextualMenu.types';
Expand Down Expand Up @@ -85,6 +85,8 @@ export class ContextualMenuSplitButton extends ContextualMenuItemWrapper {
this._ariaDescriptionId = getId();
}

const ariaChecked = getIsChecked(item) ?? undefined;

return (
<KeytipData keytipProps={keytipProps} disabled={isItemDisabled(item)}>
{(keytipAttributes: any): JSX.Element => (
Expand All @@ -102,7 +104,7 @@ export class ContextualMenuSplitButton extends ContextualMenuItemWrapper {
ariaDescription ? this._ariaDescriptionId : undefined,
keytipAttributes['aria-describedby'],
)}
aria-checked={item.isChecked || item.checked}
aria-checked={ariaChecked}
aria-posinset={focusableElementIndex + 1}
aria-setsize={totalItemCount}
onMouseEnter={this._onItemMouseEnterPrimary}
Expand Down