Skip to content

Conversation

@bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-tooltip

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0486f8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d340ff4b1c3aa7e1818780ec4d41f46c86e451c9 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 21 21 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 809 810 5000
Button mount 438 456 5000
Field mount 1517 1513 5000
FluentProvider mount 1049 1047 5000
FluentProviderWithTheme mount 135 128 10
FluentProviderWithTheme virtual-rerender 108 106 10
FluentProviderWithTheme virtual-rerender-with-unmount 120 122 10
InfoButton mount 21 21 5000 Possible regression
MakeStyles mount 1283 1298 50000
Persona mount 2253 2286 5000
SpinButton mount 1813 1792 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert
96.544 kB
23.295 kB
96.469 kB
23.454 kB
-75 B
159 B
react-avatar
Avatar
59.542 kB
15.569 kB
60.178 kB
15.854 kB
636 B
285 B
react-avatar
AvatarGroup
18.19 kB
6.706 kB
18.223 kB
6.7 kB
33 B
-6 B
react-avatar
AvatarGroupItem
75.803 kB
20.072 kB
76.404 kB
20.339 kB
601 B
267 B
react-persona
Persona
67.188 kB
17.737 kB
67.111 kB
17.793 kB
-77 B
56 B
react-tooltip
Tooltip
49.478 kB
16.853 kB
49.492 kB
16.862 kB
14 B
9 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.69 kB
18.686 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.031 kB
57.838 kB
react-components
react-components: FluentProvider & webLightTheme
38.773 kB
12.375 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-table
DataGrid
151.388 kB
41.247 kB
react-table
Table (Primitives only)
47.03 kB
12.784 kB
react-table
Table as DataGrid
133.952 kB
33.942 kB
react-table
Table (Selection only)
81.863 kB
19.962 kB
react-table
Table (Sort only)
81.193 kB
19.773 kB
🤖 This report was generated against b61892e1d2e6b8bef5b5b1ba22e08247238fb45c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 12:44
@bsunderhus bsunderhus requested review from a team, behowell and khmakoto as code owners April 18, 2023 12:44
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:52
@bsunderhus bsunderhus force-pushed the react-tooltip/chore--adopt-custom-JSX-pragma branch from e73cab2 to b0486f8 Compare April 18, 2023 18:55
@bsunderhus bsunderhus merged commit cf79cc2 into microsoft:master Apr 18, 2023
@bsunderhus bsunderhus deleted the react-tooltip/chore--adopt-custom-JSX-pragma branch April 18, 2023 19:49
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants