Skip to content

Conversation

@bsunderhus
Copy link
Contributor

New Behavior

Follow up on #27472 (comment)

  1. simplifies createElement method

@bsunderhus bsunderhus self-assigned this Apr 14, 2023
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 14, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 14, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert
96.657 kB
23.331 kB
96.544 kB
23.295 kB
-113 B
-36 B
react-components
react-components: Button, FluentProvider & webLightTheme
68.803 kB
18.728 kB
68.69 kB
18.686 kB
-113 B
-42 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.156 kB
57.857 kB
208.043 kB
57.817 kB
-113 B
-40 B
react-components
react-components: FluentProvider & webLightTheme
38.886 kB
12.41 kB
38.773 kB
12.375 kB
-113 B
-35 B
react-datepicker-compat
DatePicker Compat
252.153 kB
67.645 kB
252.04 kB
67.61 kB
-113 B
-35 B
react-dialog
Dialog (including children components)
93.413 kB
27.46 kB
93.3 kB
27.431 kB
-113 B
-29 B
react-infobutton
InfoButton
131.476 kB
39.787 kB
131.363 kB
39.748 kB
-113 B
-39 B
react-infobutton
InfoLabel
134.77 kB
40.807 kB
134.657 kB
40.767 kB
-113 B
-40 B
react-menu
Menu (including children components)
131.181 kB
39.744 kB
131.068 kB
39.705 kB
-113 B
-39 B
react-menu
Menu (including selectable components)
134.187 kB
40.281 kB
134.074 kB
40.243 kB
-113 B
-38 B
react-popover
Popover
117.751 kB
35.885 kB
117.638 kB
35.857 kB
-113 B
-28 B
react-provider
FluentProvider
20.833 kB
7.177 kB
20.72 kB
7.14 kB
-113 B
-37 B
react-table
DataGrid
151.536 kB
41.299 kB
151.423 kB
41.266 kB
-113 B
-33 B
react-table
Table (Primitives only)
47.143 kB
12.817 kB
47.03 kB
12.784 kB
-113 B
-33 B
react-table
Table as DataGrid
134.099 kB
34.001 kB
133.986 kB
33.963 kB
-113 B
-38 B
react-table
Table (Selection only)
82.011 kB
20.028 kB
81.898 kB
19.994 kB
-113 B
-34 B
react-table
Table (Sort only)
81.341 kB
19.84 kB
81.228 kB
19.805 kB
-113 B
-35 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar
59.542 kB
15.569 kB
react-avatar
AvatarGroup
18.19 kB
6.706 kB
react-avatar
AvatarGroupItem
75.803 kB
20.072 kB
react-persona
Persona
66.568 kB
17.513 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against af59ca53d4dfa7e6d80f37002ddcd4107d32b8fa

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93c9fe7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 14, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: af59ca53d4dfa7e6d80f37002ddcd4107d32b8fa (build)

@bsunderhus bsunderhus marked this pull request as ready for review April 14, 2023 10:25
@bsunderhus bsunderhus requested a review from a team as a code owner April 14, 2023 10:25
@bsunderhus bsunderhus force-pushed the react-jsx-runtime/chore--simplify-createElement-method branch from 707f1b1 to 371ac60 Compare April 14, 2023 16:46
@bsunderhus bsunderhus requested review from a team and layershifter April 14, 2023 16:47
@bsunderhus bsunderhus force-pushed the react-jsx-runtime/chore--simplify-createElement-method branch from 371ac60 to fe83965 Compare April 17, 2023 18:13
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 16 15 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 728 737 5000
Button mount 408 400 5000
Field mount 1237 1278 5000
FluentProvider mount 792 801 5000
FluentProviderWithTheme mount 103 111 10
FluentProviderWithTheme virtual-rerender 93 100 10
FluentProviderWithTheme virtual-rerender-with-unmount 104 102 10
InfoButton mount 16 15 5000 Possible regression
MakeStyles mount 1194 1190 50000
Persona mount 1981 1914 5000
SpinButton mount 1502 1498 5000

@bsunderhus bsunderhus force-pushed the react-jsx-runtime/chore--simplify-createElement-method branch from fe83965 to 93c9fe7 Compare April 18, 2023 07:49
@bsunderhus bsunderhus merged commit 391878b into microsoft:master Apr 18, 2023
@bsunderhus bsunderhus deleted the react-jsx-runtime/chore--simplify-createElement-method branch April 18, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants