-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(react-jsx-runtime): simplify createElement method #27573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bsunderhus
merged 2 commits into
microsoft:master
from
bsunderhus:react-jsx-runtime/chore--simplify-createElement-method
Apr 18, 2023
Merged
chore(react-jsx-runtime): simplify createElement method #27573
bsunderhus
merged 2 commits into
microsoft:master
from
bsunderhus:react-jsx-runtime/chore--simplify-createElement-method
Apr 18, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 93c9fe7:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: af59ca53d4dfa7e6d80f37002ddcd4107d32b8fa (build) |
packages/react-components/react-jsx-runtime/src/createElement.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-jsx-runtime/src/createElement.ts
Outdated
Show resolved
Hide resolved
707f1b1 to
371ac60
Compare
371ac60 to
fe83965
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 16 | 15 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 728 | 737 | 5000 | |
| Button | mount | 408 | 400 | 5000 | |
| Field | mount | 1237 | 1278 | 5000 | |
| FluentProvider | mount | 792 | 801 | 5000 | |
| FluentProviderWithTheme | mount | 103 | 111 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 93 | 100 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 104 | 102 | 10 | |
| InfoButton | mount | 16 | 15 | 5000 | Possible regression |
| MakeStyles | mount | 1194 | 1190 | 50000 | |
| Persona | mount | 1981 | 1914 | 5000 | |
| SpinButton | mount | 1502 | 1498 | 5000 |
layershifter
approved these changes
Apr 17, 2023
layershifter
approved these changes
Apr 17, 2023
fe83965 to
93c9fe7
Compare
fabricteam
reviewed
Apr 18, 2023
change/@fluentui-react-jsx-runtime-e321b00b-0fc8-427c-bb82-36948756d961.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

New Behavior
Follow up on #27472 (comment)
createElementmethod