Skip to content

feat(react-provider): adopt custom JSX pragma #27547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Apr 15, 2023
Merged

feat(react-provider): adopt custom JSX pragma #27547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-provider-01464521-6329-44ea-be05-8aa792d0462b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "feat: adopt custom JSX pragma",
"packageName": "@fluentui/react-provider",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-provider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"@fluentui/react-tabster": "^9.6.4",
"@fluentui/react-theme": "^9.1.7",
"@fluentui/react-utilities": "^9.7.4",
"@fluentui/react-jsx-runtime": "^9.0.0-alpha.0",
"@swc/helpers": "^0.4.14"
},
"peerDependencies": {
Expand Down
9 changes: 6 additions & 3 deletions ...es/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import * as React from 'react';
/** @jsxRuntime classic */
/** @jsx createElement */

import { createElement } from '@fluentui/react-jsx-runtime';
import { canUseDOM, getSlotsNext } from '@fluentui/react-utilities';
import { TextDirectionProvider } from '@griffel/react';
import {
OverridesProvider_unstable as OverridesProvider,
Expand All @@ -9,7 +13,6 @@ import {
CustomStyleHooksProvider_unstable as CustomStyleHooksProvider,
CustomStyleHooksContextValue_unstable as CustomStyleHooksContextValue,
} from '@fluentui/react-shared-contexts';
import { canUseDOM, getSlots } from '@fluentui/react-utilities';
import type { FluentProviderContextValues, FluentProviderState, FluentProviderSlots } from './FluentProvider.types';

/**
Expand All @@ -19,7 +22,7 @@ export const renderFluentProvider_unstable = (
state: FluentProviderState,
contextValues: FluentProviderContextValues,
) => {
const { slots, slotProps } = getSlots<FluentProviderSlots>(state);
const { slots, slotProps } = getSlotsNext<FluentProviderSlots>(state);

// Typescript (vscode) incorrectly references the FluentProviderProps.customStyleHooks_unstable
// instead of FluentProviderContextValues.customStyleHooks_unstable and thinks it is
Expand Down