Skip to content

Enable export to codepen for charting library #27539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AtishayMsft merged 16 commits into from
Apr 26, 2023
Merged

Enable export to codepen for charting library #27539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bd08b74
Fix triangle pyramid shape
AtishayMsft Apr 10, 2023
b6fb8c2
Add changefile
AtishayMsft Apr 10, 2023
a6542c7
Add react charting to fabric group
AtishayMsft Apr 13, 2023
a03a93f
Add change file
AtishayMsft Apr 13, 2023
31c6380
Add test change in line chart
AtishayMsft Apr 13, 2023
61a68ae
Add react charting to codepen supported packages
AtishayMsft Apr 13, 2023
1d026ff
Test adding charting as dependency for monaco editor
AtishayMsft Apr 13, 2023
814d183
Add charting package as default supported
AtishayMsft Apr 17, 2023
00b8c96
Add change file for react docsite component
AtishayMsft Apr 17, 2023
e7e66ba
Put charting package under a condition
AtishayMsft Apr 17, 2023
e3b70d3
Update line chart color
AtishayMsft Apr 17, 2023
aebe1ad
Add null check for window
AtishayMsft Apr 17, 2023
b4ce7c1
Add undefined check
AtishayMsft Apr 18, 2023
4b852aa
Line chart changes
AtishayMsft Apr 18, 2023
b9c6944
Fix window typeof
AtishayMsft Apr 18, 2023
3babbf1
Revert test changes
AtishayMsft Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-docsite-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Enable export to codepen for react charting",
"packageName": "@fluentui/react-docsite-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add react charting to support export to codepen",
"packageName": "@fluentui/react-monaco-editor",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/react-docsite-components/src/components/CodepenComponent/CodepenComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ const CodepenComponentBase: React.FunctionComponent<ICodepenProps> = props => {
jsContentStr.indexOf('window.FluentUIExampleData') !== -1
? script('@fluentui/example-data@8/dist/example-data.js')
: '',
// load charting bundle only if used
jsContentStr.indexOf('window.FluentUIReactCharting') !== -1
? script('@fluentui/react-charting@5/dist/react-charting.js')
: '',
`<div id="${CONTENT_ID}"></div>`,
]
.filter(line => !!line)
Expand Down
12 changes: 10 additions & 2 deletions packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ const exampleDataGroup: IPackageGroup = {
loadGlobal: cb => require.ensure([], require => cb(require('@fluentui/example-data'))),
packages: [],
};
const chartingGroup: IPackageGroup = {
globalName: 'FluentUIReactCharting',
loadGlobal: cb => require.ensure([], require => cb(require('@fluentui/react-charting'))),
packages: [],
};

let typesContext: __WebpackModuleApi.RequireContext | undefined;
try {
Expand All @@ -32,6 +37,7 @@ try {
} catch (ex) {
// We're probably running in jest, which doesn't have webpack's require.context
}
const loadTypes = () => '';
if (typesContext) {
typesContext.keys().forEach(dtsPath => {
// The api-extractor .d.ts rollups use the package's unscoped name (such as "utilities")
Expand All @@ -57,7 +63,6 @@ if (typesContext) {
});
} else {
// Use some defaults for jest tests (real types won't be loaded)
const loadTypes = () => '';
fabricGroup.packages.push(
{ packageName: '@fluentui/date-time-utilities', loadTypes },
{ packageName: '@fluentui/dom-utilities', loadTypes },
Expand All @@ -74,9 +79,12 @@ if (typesContext) {
hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes });
exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes });
}
if (typeof window === 'object' && window.location.href.indexOf('react-charting') !== -1) {
chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes });
}

/**
* Default supported packages for imports: `@fluentui/react` and everything it exports,
* plus `@fluentui/example-data`. (React is implicitly supported.)
*/
export const SUPPORTED_PACKAGES: IPackageGroup[] = [fabricGroup, hooksGroup, exampleDataGroup];
export const SUPPORTED_PACKAGES: IPackageGroup[] = [fabricGroup, hooksGroup, exampleDataGroup, chartingGroup];