-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(react-tree): value property over id #27532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-tree/feat--value-property-over-id
Apr 19, 2023
Merged
feat(react-tree): value property over id #27532
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-tree/feat--value-property-over-id
Apr 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 22 | 19 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 711 | 695 | 5000 | |
| Button | mount | 381 | 366 | 5000 | |
| Field | mount | 1272 | 1239 | 5000 | |
| FluentProvider | mount | 871 | 860 | 5000 | |
| FluentProviderWithTheme | mount | 110 | 116 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 91 | 101 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 104 | 108 | 10 | |
| InfoButton | mount | 22 | 19 | 5000 | Possible regression |
| MakeStyles | mount | 1134 | 1132 | 50000 | |
| Persona | mount | 1952 | 1906 | 5000 | |
| SpinButton | mount | 1591 | 1527 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e5c39d1494652e5803b6e8822a2e3fb894aec811 (build) |
1c23610 to
01517ec
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4397720:
|
582cd2e to
ec25d6a
Compare
ec25d6a to
4397720
Compare
george-cz
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
idattribute would be used internally to decide whether or not a tree node is opened or closedNew Behavior
valueproperty to work as a reference to decide wether or not a node is opened or closedidas the default value forvalueproperty in the default case to simplify basic usage.Related Issue(s)