Skip to content

fix: BasePickerListBelow aria-describedby with values #27525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 2 commits into from
Apr 12, 2023
Merged

fix: BasePickerListBelow aria-describedby with values #27525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d55d5e7
fix: BasePicker below uses aria-describedby
smhigley Apr 11, 2023
0e61036
change file
smhigley Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-cc684d1e-b561-490a-a648-47ece08bdc45.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: the BasePicker with List Below variant now sets aria-describedby pointing to selected values",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6 changes: 5 additions & 1 deletion packages/react/src/components/pickers/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,9 @@ export class BasePickerListBelow<T, P extends IBasePickerProps<T>> extends BaseP
<div ref={this.root} onBlur={this.onBlur} onFocus={this.onFocus}>
<div className={classNames.root} onKeyDown={this.onKeyDown}>
{this.renderCustomAlert(classNames.screenReaderText)}
<span id={`${this._ariaMap.selectedItems}-label`} hidden>
{selectionAriaLabel || comboLabel}
</span>
<div className={classNames.text} aria-owns={suggestionsAvailable}>
<Autofill
{...(inputProps as any)}
Expand All @@ -1128,6 +1131,7 @@ export class BasePickerListBelow<T, P extends IBasePickerProps<T>> extends BaseP
aria-expanded={suggestionsVisible}
aria-haspopup="listbox"
aria-label={comboLabel}
aria-describedby={this.state.items.length > 0 ? this._ariaMap.selectedItems : undefined}
role="combobox"
id={inputProps?.id ? inputProps.id : this._ariaMap.combobox}
disabled={disabled}
Expand All @@ -1141,7 +1145,7 @@ export class BasePickerListBelow<T, P extends IBasePickerProps<T>> extends BaseP
id={this._ariaMap.selectedItems}
className="ms-BasePicker-selectedItems" // just a className hook without any styles applied to it.
role={selectionRole}
aria-label={selectionAriaLabel || comboLabel}
aria-labelledby={`${this._ariaMap.selectedItems}-label`}
>
{this.renderItems()}
</div>
Expand Down