Skip to content

fix: react-combobox defines fallbackPositions for popup on small screens #27521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 3 commits into from
Apr 11, 2023
Merged

fix: react-combobox defines fallbackPositions for popup on small screens #27521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddd5c96
fix: react-combobox uses fallbackPositions for popup
smhigley Apr 11, 2023
ea313cd
change file
smhigley Apr 11, 2023
442b3b3
Update changefile wording
smhigley Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-combobox-c627d0c3-82f4-4593-8a10-546a41227e16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: popup now defines fallbackPositions to use when it doesn't fit the screen",
"packageName": "@fluentui/react-combobox",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6 changes: 5 additions & 1 deletion packages/react-components/react-combobox/src/utils/useComboboxPopup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { resolvePositioningShorthand, usePositioning } from '@fluentui/react-positioning';
import { PositioningShorthandValue, resolvePositioningShorthand, usePositioning } from '@fluentui/react-positioning';
import { ExtractSlotProps, Slot, useMergedRefs } from '@fluentui/react-utilities';
import type { ComboboxBaseProps } from './ComboboxBase.types';
import { Listbox } from '../components/Listbox/Listbox';
Expand All @@ -24,11 +24,15 @@ export function useComboboxPopup(
] {
const { positioning } = props;

// Set a default set of fallback positions to try if the dropdown does not fit on screen
const fallbackPositions: PositioningShorthandValue[] = ['above', 'after', 'after-top', 'before', 'before-top'];

// popper options
const popperOptions = {
position: 'below' as const,
align: 'start' as const,
offset: { crossAxis: 0, mainAxis: 2 },
fallbackPositions,
...resolvePositioningShorthand(positioning),
};

Expand Down