Skip to content

Conversation

@behowell
Copy link
Contributor

@behowell behowell commented Apr 10, 2023

Previous Behavior

Combobox/Dropdown stories import directly from react-combobox. This causes the lint rule @fluentui/no-restricted-imports to fail in unrelated PRs, such as #27492. (I'm not sure why the lint rule isn't failing in the main build...)

New Behavior

Change Combobox/Dropdown stories to import from react-components instead of react-combobox.

Related Issue(s)

Similar fixes in other packages:

@behowell behowell self-assigned this Apr 10, 2023
@behowell behowell requested review from a team and smhigley as code owners April 10, 2023 21:29
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 10, 2023
@behowell behowell enabled auto-merge (squash) April 10, 2023 21:36
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2527e6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
89.718 kB
28.49 kB
react-combobox
Dropdown (including child components)
88.402 kB
28.217 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.512 kB
57.555 kB
react-components
react-components: FluentProvider & webLightTheme
38.819 kB
12.351 kB
react-datepicker-compat
DatePicker Compat
251.272 kB
67.329 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-select
Select
27.915 kB
9.189 kB
🤖 This report was generated against 72acd40b2319325eb725760888185a2fabdd46e7

@size-auditor
Copy link

size-auditor bot commented Apr 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d641ed3418a70dbcfcc29ca56acb4f2711551044 (build)

@behowell behowell disabled auto-merge April 10, 2023 21:47
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 22 27 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 817 823 5000
Button mount 435 441 5000
Field mount 1464 1458 5000
FluentProvider mount 1050 1032 5000
FluentProviderWithTheme mount 124 131 10
FluentProviderWithTheme virtual-rerender 111 104 10
FluentProviderWithTheme virtual-rerender-with-unmount 126 122 10
InfoButton mount 22 27 5000 Possible regression
MakeStyles mount 1299 1312 50000
Persona mount 2324 2340 5000
SpinButton mount 1848 1855 5000

@behowell behowell requested review from a team and sopranopillow as code owners April 10, 2023 22:11
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@behowell behowell merged commit b405bd8 into microsoft:master Apr 10, 2023
@behowell behowell deleted the combobox/fix-story-imports branch April 10, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants