-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(react-combobox): Stories should import from react-components #27508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
behowell
merged 3 commits into
microsoft:master
from
behowell:combobox/fix-story-imports
Apr 10, 2023
Merged
fix(react-combobox): Stories should import from react-components #27508
behowell
merged 3 commits into
microsoft:master
from
behowell:combobox/fix-story-imports
Apr 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
approved these changes
Apr 10, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b2527e6:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d641ed3418a70dbcfcc29ca56acb4f2711551044 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 22 | 27 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 817 | 823 | 5000 | |
| Button | mount | 435 | 441 | 5000 | |
| Field | mount | 1464 | 1458 | 5000 | |
| FluentProvider | mount | 1050 | 1032 | 5000 | |
| FluentProviderWithTheme | mount | 124 | 131 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 111 | 104 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 126 | 122 | 10 | |
| InfoButton | mount | 22 | 27 | 5000 | Possible regression |
| MakeStyles | mount | 1299 | 1312 | 50000 | |
| Persona | mount | 2324 | 2340 | 5000 | |
| SpinButton | mount | 1848 | 1855 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Combobox/Dropdown stories import directly from react-combobox. This causes the lint rule
@fluentui/no-restricted-importsto fail in unrelated PRs, such as #27492. (I'm not sure why the lint rule isn't failing in the main build...)New Behavior
Change Combobox/Dropdown stories to import from react-components instead of react-combobox.
Related Issue(s)
Similar fixes in other packages: