Skip to content

[Feature]: allow aria-description attribute on v9 #27478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petdud merged 4 commits into from
Apr 12, 2023
Merged

[Feature]: allow aria-description attribute on v9 #27478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b44cd5
valid
Apr 6, 2023
547ece4
Update apps/ssr-tests-v9/src/utils/visitPage.ts
petdud Apr 11, 2023
ee30885
Update apps/ssr-tests-v9/src/utils/visitPage.ts
petdud Apr 11, 2023
a8d9728
helper fn
Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/ssr-tests-v9/src/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ export function hrToSeconds(hrtime: ReturnType<typeof process.hrtime>): string {

return raw.toFixed(2) + 's';
}

export function containsAriaDescriptionWarning(message: string): boolean {
return message.startsWith(
'Warning: Invalid aria prop %s on <%s> tag. For details, see https://reactjs.org/link/invalid-aria-props%s `aria-description`',
);
}
14 changes: 12 additions & 2 deletions apps/ssr-tests-v9/src/utils/visitPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import type { Browser } from 'puppeteer';
import { visitUrl } from '@fluentui/scripts-puppeteer';
import { PROVIDER_ID } from './constants';
import * as React from 'react';
import { containsAriaDescriptionWarning } from './helpers';

class RenderError extends Error {
public name = 'RangeError';
Expand All @@ -14,9 +16,17 @@ export async function visitPage(browser: Browser, url: string) {

page.on('console', message => {
if (message.type() === 'error') {
const messageContent = message.text();

// Ignoring 'aria-description' warning from react 17 as it's a valid prop
// https://github.com/facebook/react/issues/21035
if (containsAriaDescriptionWarning(messageContent) && React.version.startsWith('17')) {
return;
}

// Ignoring network errors as we have an interceptor that prevents loading everything except our JS bundle
if (!message.text().includes('net::ERR_FAILED')) {
error = new RenderError(message.text());
if (!messageContent.includes('net::ERR_FAILED')) {
error = new RenderError(messageContent);
}
}
});
Expand Down