Skip to content

Conversation

@behowell
Copy link
Contributor

@behowell behowell commented Apr 5, 2023

New Behavior

Update Field's spec.md to describe the new method of passing field state via context instead of setting props directly on the child.

Related Issue(s)

@behowell behowell marked this pull request as ready for review April 5, 2023 22:23
@behowell behowell requested a review from a team as a code owner April 5, 2023 22:23
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 5, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-checkbox
Checkbox
37.02 kB
11.255 kB
react-combobox
Combobox (including child components)
89.718 kB
28.49 kB
react-combobox
Dropdown (including child components)
88.402 kB
28.217 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.512 kB
57.555 kB
react-components
react-components: FluentProvider & webLightTheme
38.819 kB
12.351 kB
react-datepicker-compat
DatePicker Compat
251.272 kB
67.329 kB
react-field
Field
21.509 kB
7.408 kB
react-input
Input
26.707 kB
8.113 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-progress
ProgressBar
16.322 kB
5.822 kB
react-radio
Radio
35.48 kB
11.126 kB
react-radio
RadioGroup
18.889 kB
6.929 kB
react-select
Select
27.915 kB
9.189 kB
react-slider
Slider
36.845 kB
11.474 kB
react-spinbutton
SpinButton
36.615 kB
10.757 kB
react-switch
Switch
32.438 kB
9.706 kB
react-table
DataGrid
150.829 kB
41.052 kB
react-table
Table (Primitives only)
47.119 kB
12.703 kB
react-table
Table as DataGrid
138.971 kB
35.722 kB
react-table
Table (Selection only)
86.8 kB
21.742 kB
react-table
Table (Sort only)
86.13 kB
21.549 kB
react-textarea
Textarea
30.108 kB
9.478 kB
🤖 This report was generated against d8f32b68ec87fa322f72616f3e9d21cb679cc205

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14a247a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 5, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 694 698 5000
Button mount 382 371 5000
Field mount 1259 1256 5000
FluentProvider mount 908 875 5000
FluentProviderWithTheme mount 116 119 10
FluentProviderWithTheme virtual-rerender 96 104 10
FluentProviderWithTheme virtual-rerender-with-unmount 108 113 10
InfoButton mount 20 24 5000
MakeStyles mount 1134 1115 50000
Persona mount 1999 1984 5000
SpinButton mount 1578 1581 5000

@size-auditor
Copy link

size-auditor bot commented Apr 5, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d8f32b68ec87fa322f72616f3e9d21cb679cc205 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 5, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@behowell behowell enabled auto-merge (squash) April 7, 2023 16:22
@behowell behowell merged commit 08d6a93 into microsoft:master Apr 7, 2023
@behowell behowell deleted the field/context-spec branch February 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants