fix: add default heading level to DialogTitle #27452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 28ab635:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 689 | 690 | 5000 | |
| Button | mount | 375 | 373 | 5000 | |
| Field | mount | 1257 | 1268 | 5000 | |
| FluentProvider | mount | 874 | 855 | 5000 | |
| FluentProviderWithTheme | mount | 112 | 116 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 87 | 97 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 101 | 106 | 10 | |
| InfoButton | mount | 21 | 18 | 5000 | |
| MakeStyles | mount | 1111 | 1117 | 50000 | |
| Persona | mount | 1979 | 1912 | 5000 | |
| SpinButton | mount | 1528 | 1546 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: af3c827937dcb0a32f52ef8a93b91c1276956b56 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
spmonahan
approved these changes
Apr 6, 2023
Contributor
|
We've been discussing the possibility of using |
Contributor
|
@smhigley I'm closing this one, since its been fixed by Bernardo's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Our v9 DialogTitle defaults to generic text, even though it is displayed as a heading.
New Behavior
By default, it has
role=heading aria-level=2. I didn't want to change the default tag, though if we go for a major version change in the future, defaulting toas: h2would be better.