Skip to content

fix(ts-minbar-test-react): pin @types/react as temporary workaround for breaking changes introduced by definitely typed package #27426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 1 commit into from
Apr 4, 2023
Merged

fix(ts-minbar-test-react): pin @types/react as temporary workaround for breaking changes introduced by definitely typed package #27426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/ts-minbar-test-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as fs from 'fs';
import * as path from 'path';

import {
Expand All @@ -24,10 +25,13 @@ async function performTest() {
tempPaths = prepareTempDirs(`${testName}-`);
logger(`✔️ Temporary directories created under ${tempPaths.root}`);

// https://github.com/microsoft/fluentui/issues/27425 - remove related logic once issue will be resolved
const pinnedReactTypesVersion = '17.0.55';

// Install dependencies, using the minimum TS version supported for consumers
const dependencies = [
'@types/node@14',
'@types/react@17',
`@types/react@${pinnedReactTypesVersion}`,
'@types/react-dom@17',
'react@17',
'react-dom@17',
Expand All @@ -40,6 +44,13 @@ async function performTest() {
const packedPackages = await packProjectPackages(logger, lernaRoot, ['@fluentui/react']);
await addResolutionPathsForProjectPackages(tempPaths.testApp);

// Remove Start - once will be resolved https://github.com/microsoft/fluentui/issues/27425
const jsonPath = path.resolve(tempPaths.testApp, 'package.json');
const packageJson = JSON.parse(fs.readFileSync(jsonPath, 'utf-8'));
packageJson.resolutions['@types/react-dom/@types/react'] = pinnedReactTypesVersion;
fs.writeFileSync(jsonPath, JSON.stringify(packageJson), 'utf-8');
// Remove End

await shEcho(`yarn add ${packedPackages['@fluentui/react']}`, tempPaths.testApp);
logger(`✔️ Fluent UI packages were added to dependencies`);

Expand Down