Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 3, 2023

Previous Behavior

Introduction of extends with custom v9 preset within babelrc configs broke _processBabelLoaderOptions, thus griffel preset was used during storybook builds. While on pure v9 packages, things mostly still worked as expected cross project storybooks stopped working triggering following build errors:

Failure for @fluentui/react-migration-v8-v9:

image

New Behavior

  • we now exclude custom '@fluentui/scripts-babel/preset-v9' for storybook babel-loader. This mitigates any issues
  • identity aliases for codesandbox babel plugin has been refactored, including excluding non relevant packages from mapping

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 3, 2023
@Hotell Hotell changed the title Hotell/build/fix storybooks babel presets fix(scripts-storybook): make sure to exclude our custom v9 babel preset from storybook babel-loader Apr 3, 2023
@Hotell Hotell marked this pull request as ready for review April 3, 2023 16:57
@Hotell Hotell requested a review from a team as a code owner April 3, 2023 16:57
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df37136:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 3, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8c1140461454f55359a4d329f376e8f5bc401e02 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 8c1140461454f55359a4d329f376e8f5bc401e02

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell merged commit 23ad7e9 into microsoft:master Apr 5, 2023
@Hotell Hotell deleted the hotell/build/fix-storybooks-babel-presets branch April 5, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants