Azure Theme 7.0 dropdown fix for high contrast themes #27345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
the
needs cherry-pick
msft-fluent-ui-bot
previously requested changes
Mar 27, 2023
Collaborator
msft-fluent-ui-bot
left a comment
msft-fluent-ui-bot
left a comment
There was a problem hiding this comment.
It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
masterwith this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c840ff:
|
|
You have successfully added a new CodeQL configuration |
Collaborator
🕵 FluentUI-v7 Open the Visual Regressions report to inspect the 31 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1342 screenshots unchanged, 0 screenshots with different dimensions and 31 screenshots with visible difference. unknown 31 screenshots
|
Contributor
Author
|
Cherry-picked into 8.0 via #27346 |
Jacqueline-ms
dismissed
msft-fluent-ui-bot’s stale review
This has been cherry-picked into main
Collaborator
Perf AnalysisNo significant results to display. All results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
High contrast light had style bug on selected and hover
High contrast dark had style bug on selected and hover
New Behavior
High contrast light
High contrast dark
Showing light and dark themes dropdown to prove no new bugs introduced.
Light: