Skip to content

add codeowners to theme designer v9 #27311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micahgodbolt merged 3 commits into from
Apr 11, 2023
Merged

add codeowners to theme designer v9 #27311

micahgodbolt merged 3 commits into from
Apr 11, 2023

Conversation

@micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented Mar 23, 2023

new devs are going to be driving the theme designer effort with target of making it ready for build

@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 23, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 23, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 263ea175b5da60d0abacc0eec88d7c338ce5c74a

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 23, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3be1a5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 23, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 263ea175b5da60d0abacc0eec88d7c338ce5c74a (build)

@JustSlone
Copy link
Collaborator

JustSlone commented Mar 23, 2023

@JinCodesAgain and @tibell_microsoft don't appear to be github accounts?
@ms-acalzaretto can you join the Microsoft organization? via the internal portal so we can add you to the team we use to manage permissions

@ms-acalzaretto
Copy link
Contributor

ms-acalzaretto commented Mar 24, 2023 •
edited
Loading

@JinCodesAgain and @tibell_microsoft don't appear to be github accounts? @ms-acalzaretto can you join the Microsoft organization? via the internal portal so we can add you to the team we use to manage permissions

Joined -- I also updated Jin/Tim on joining as well. Waiting on them

@JustSlone
Copy link
Collaborator

JustSlone commented Mar 28, 2023

@JinCodesAgain and @tibell_microsoft don't appear to be github accounts? @ms-acalzaretto can you join the Microsoft organization? via the internal portal so we can add you to the team we use to manage permissions

Joined -- I also updated Jin/Tim on joining as well. Waiting on them

Thanks, let us know when they join and if their GitHub user names are still accurate, they don't' seem to be resolving in the GitHub UI

@JustSlone
Copy link
Collaborator

JustSlone commented Mar 30, 2023

@ms-acalzaretto any news on our other friends accounts?
We could merge this with just you as owner for now, we can always add more folks later if needed.

@ms-acalzaretto
Copy link
Contributor

ms-acalzaretto commented Mar 30, 2023

It's fine to just merge me as owner!

JustSlone
JustSlone reviewed Mar 31, 2023
View reviewed changes
@micahgodbolt micahgodbolt merged commit 545c3ef into microsoft:master Apr 11, 2023
@micahgodbolt micahgodbolt deleted the theme-designer-owners branch April 11, 2023 15:23
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 13, 2023
@marcosmoura
Merge branch 'marcosmoura/feat/drawer-component' into marcosmoura/fea…
548d190 
…t/drawer-light-dismiss-prop

* marcosmoura/feat/drawer-component: (51 commits)
  fix: upgrade react-dialog
  Doc: Add/Remove TreeItem and useFlatTree stories (microsoft#27515)
  applying package updates
  Fix accessibility labels for tree stories (microsoft#27443)
  fix: BasePickerListBelow aria-describedby with values (microsoft#27525)
  chore: Remove deprecated InputField, etc. shim components (microsoft#27492)
  [Feature]: allow aria-description attribute on v9 (microsoft#27478)
  feat(react-jsx-runtime): implements custom JSX pragma (microsoft#27472)
  chore: update generator to include "test-ssr" script (microsoft#27463)
  applying package updates
  fix: add "style" to exports field (microsoft#27274)
  applying package updates
  feat(react-datepicker-compat): Make package public (microsoft#27524)
  fix: react-combobox defines fallbackPositions for popup on small screens (microsoft#27521)
  fix: use tabster to focus on trigger, instead of manually invoking .focus (microsoft#27512)
  add cxe-red to react-shared-context ownership (microsoft#27296)
  docs: add props tables for all exported Popover controls (microsoft#27503)
  fix: Update FormFieldShim to work with Field context changes (microsoft#27436)
  Fix wrong state narration for multiple selected legends (microsoft#27429)
  add codeowners to theme designer v9 (microsoft#27311)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustSlone JustSlone JustSlone approved these changes

@ms-acalzaretto ms-acalzaretto ms-acalzaretto approved these changes

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@behowell behowell

Labels

None yet

Projects

None yet

Milestone

March Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

6 participants

@micahgodbolt @fabricteam @JustSlone @ms-acalzaretto @ling1726 @behowell