Skip to content

fix: Embed play/pause indicator should render correctly in high contrast mode #27213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling1726 merged 5 commits into from
Mar 15, 2023
Merged

fix: Embed play/pause indicator should render correctly in high contrast mode #27213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f94f9f7
fix: Embed play/pause indicator should render correctly in high contr…
ling1726 Mar 15, 2023
b7aab66
add changelog
ling1726 Mar 15, 2023
5f97545
Merge branch 'master' into fix/embed-indicator-hc
ling1726 Mar 15, 2023
6db0257
use variables instead
ling1726 Mar 15, 2023
eaf6a42
Merge branch 'fix/embed-indicator-hc' of https://github.com/ling1726/…
ling1726 Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fluentui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- `Datepicker`: indicators should be visible in high contrast mode. @ling1726 ([#27107](https://github.com/microsoft/fluentui/pull/27107))
- `Datepicker`: Disabled buttons should be green in HC theme. @jurokapsiar ([#27114](https://github.com/microsoft/fluentui/pull/27114))
- `SplitButton`: should display correctly in high contrast mode @ling1726 ([#27137](https://github.com/microsoft/fluentui/pull/27137))
- `Embed`: play/pause indicator should render correctly in high contrast mode @ling1726 ([#27213](https://github.com/microsoft/fluentui/pull/27213))

<!--------------------------------[ v0.66.3 ]------------------------------- -->
## [v0.66.3](https://github.com/microsoft/fluentui/tree/@fluentui/react-northstar_v0.66.3) (2023-02-27)
Expand Down
1 change: 1 addition & 0 deletions packages/fluentui/react-northstar/src/themes/teams-forced-colors/componentVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { embedVariables as Embed } from './components/Embed/embedVariables';
7 changes: 7 additions & 0 deletions ...luentui/react-northstar/src/themes/teams-forced-colors/components/Embed/embedVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { EmbedVariables } from '../../../teams/components/Embed/embedVariables';

export const embedVariables = (): Partial<EmbedVariables> => {
return {
controlColor: 'ButtonText',
};
};
2 changes: 2 additions & 0 deletions packages/fluentui/react-northstar/src/themes/teams-forced-colors/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { createTheme, mergeThemes } from '@fluentui/styles';
import { teamsHighContrastTheme } from '../teams-high-contrast';
import * as componentStyles from './componentStyles';
import * as componentVariables from './componentVariables';

export const teamsForcedColorsTheme = mergeThemes(
teamsHighContrastTheme,
createTheme(
{
componentStyles,
componentVariables,
},
'teams-forced-colors',
),
Expand Down