Skip to content

[Fluent 2 Theme] Fixing link color in dark theme #27203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mltejera merged 4 commits into from
Mar 23, 2023
Merged

[Fluent 2 Theme] Fixing link color in dark theme #27203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11e8547
Link color fixes
mltejera Mar 14, 2023
23f2b56
change file
mltejera Mar 14, 2023
6728558
add comment
mltejera Mar 14, 2023
5f4b90b
Merge branch 'master' into user/matejera/fluent2-theme-link-color-fixes
mltejera Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-fluent2-theme-7178a475-283a-4603-9003-fff3693e78ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Updating Link text color in dark theme to match Fluent 2.",
"packageName": "@fluentui/fluent2-theme",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/fluent2-theme/src/fluent2WebDarkTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ const p = fluent2ForV8DarkPalette;
const grey36 = '#5C5C5C';

const semanticColorMappingOverridesForDark: Partial<IExtendedSemanticColors> = {
// This hex matches the v9 theme.
link: p.themeDark,

// Extended semantic colors
inputBottomBorderFocus: p.themePrimary,
inputBottomBorderRest: p.neutralLighter,
Expand Down