chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map #27154

TristanWatanabe · 2023-03-09T23:51:50Z

Follows #27152

runs migrate-converged-pkg workspace generator to add node field to each v9 package's package.json exports map.
ONLY the change to add the node field to the package.json of each v9 package have been committed in this PR.

Related Issue(s)

Fixes [Bug]: usage of import in Node is broken because of export maps #26176

size-auditor · 2023-03-10T00:04:49Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 189ef97151c54eb6458b19141f093ed6ef376b48 (build)

codesandbox-ci · 2023-03-10T00:06:50Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f067acd:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-03-10T00:12:34Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	872	867	5000
Button	mount	571	562	5000
Field	mount	1489	1474	5000
FluentProvider	mount	1030	1040	5000
FluentProviderWithTheme	mount	270	261	10
FluentProviderWithTheme	virtual-rerender	209	209	10
FluentProviderWithTheme	virtual-rerender-with-unmount	266	269	10
InfoButton	mount	179	189	5000
MakeStyles	mount	1376	1370	50000
Persona	mount	2107	2008	5000
SpinButton	mount	1806	1797	5000

fabricteam · 2023-03-10T00:12:58Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.314 kB`
`react-accordion` Accordion (including children components)	`88.789 kB` `26.532 kB`
`react-alert` Alert	`90.467 kB` `22.106 kB`
`react-avatar` Avatar	`54.149 kB` `14.571 kB`
`react-avatar` AvatarGroup	`18.064 kB` `6.664 kB`
`react-avatar` AvatarGroupItem	`70.425 kB` `19.075 kB`
`react-badge` Badge	`25.746 kB` `7.568 kB`
`react-badge` CounterBadge	`26.725 kB` `7.874 kB`
`react-badge` PresenceBadge	`28.318 kB` `7.779 kB`
`react-button` Button	`39.613 kB` `9.935 kB`
`react-button` CompoundButton	`46.795 kB` `11.405 kB`
`react-button` MenuButton	`44.296 kB` `11.255 kB`
`react-button` SplitButton	`52.846 kB` `12.866 kB`
`react-button` ToggleButton	`57.982 kB` `11.853 kB`
`react-card` Card - All	`83.548 kB` `23.894 kB`
`react-card` Card	`78.317 kB` `22.433 kB`
`react-card` CardFooter	`9.045 kB` `3.806 kB`
`react-card` CardHeader	`10.984 kB` `4.509 kB`
`react-card` CardPreview	`9.852 kB` `4.159 kB`
`react-checkbox` Checkbox	`35.895 kB` `10.82 kB`
`react-checkbox` CheckboxField	`42.8 kB` `12.714 kB`
`react-combobox` Combobox (including child components)	`88.7 kB` `28.099 kB`
`react-combobox` ComboboxField	`85.066 kB` `27.838 kB`
`react-combobox` Dropdown (including child components)	`87.387 kB` `27.842 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`67.15 kB` `18.121 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`206.317 kB` `57.147 kB`
`react-components` react-components: FluentProvider & webLightTheme	`37.981 kB` `12.053 kB`
`react-dialog` Dialog (including children components)	`92.72 kB` `27.216 kB`
`react-divider` Divider	`19.754 kB` `6.68 kB`
`react-field` Field	`20.397 kB` `7.053 kB`
`react-image` Image	`13.897 kB` `4.974 kB`
`react-infobutton` InfoButton	`130.438 kB` `39.407 kB`
`react-infobutton` InfoLabel	`133.754 kB` `40.454 kB`
`react-input` Input	`25.664 kB` `7.695 kB`
`react-input` InputField	`35.613 kB` `10.592 kB`
`react-label` Label	`12.461 kB` `4.57 kB`
`react-link` Link	`12.306 kB` `5.073 kB`
`react-menu` Menu (including children components)	`130.333 kB` `39.499 kB`
`react-menu` Menu (including selectable components)	`133.509 kB` `40.037 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`61.21 kB` `16.521 kB`
`react-popover` Popover	`117.51 kB` `35.799 kB`
`react-portal` Portal	`11.715 kB` `4.265 kB`
`react-portal-compat` PortalCompatProvider	`6.324 kB` `2.129 kB`
`react-positioning` usePositioning	`24.01 kB` `8.793 kB`
`react-progress` ProgressBar	`15.846 kB` `5.658 kB`
`react-progress` ProgressField	`26.289 kB` `8.819 kB`
`react-provider` FluentProvider	`19.928 kB` `6.832 kB`
`react-radio` Radio	`35.392 kB` `11.117 kB`
`react-radio` RadioGroup	`17.872 kB` `6.523 kB`
`react-radio` RadioGroupField	`28.023 kB` `9.681 kB`
`react-select` Select	`26.87 kB` `8.761 kB`
`react-select` SelectField	`36.179 kB` `11.28 kB`
`react-slider` Slider	`35.816 kB` `11.043 kB`
`react-slider` SliderField	`45.717 kB` `13.975 kB`
`react-spinbutton` SpinButton	`35.559 kB` `10.351 kB`
`react-spinbutton` SpinButtonField	`44.565 kB` `12.765 kB`
`react-spinner` Spinner	`23.336 kB` `7.18 kB`
`react-switch` Switch	`30.943 kB` `9.25 kB`
`react-switch` SwitchField	`37.805 kB` `11.148 kB`
`react-table` DataGrid	`149.792 kB` `40.502 kB`
`react-table` Table (Primitives only)	`46.798 kB` `12.557 kB`
`react-table` Table as DataGrid	`137.684 kB` `35.154 kB`
`react-table` Table (Selection only)	`85.511 kB` `21.173 kB`
`react-table` Table (Sort only)	`84.832 kB` `20.982 kB`
`react-text` Text - Default	`14.898 kB` `5.31 kB`
`react-text` Text - Wrappers	`15.571 kB` `5.23 kB`
`react-textarea` Textarea	`28.981 kB` `9.071 kB`
`react-textarea` TextareaField	`39.334 kB` `12.008 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`49.351 kB` `16.799 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 189ef97151c54eb6458b19141f093ed6ef376b48}

fabricteam · 2023-03-10T00:14:29Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2023-03-10T00:19:25Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-03-10T00:19:29Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-03-10T00:33:17Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	996	996	5000
Breadcrumb	mount	2365	2375	1000
Checkbox	mount	2280	2221	5000
CheckboxBase	mount	1991	2008	5000
ChoiceGroup	mount	3870	3866	5000
ComboBox	mount	1055	1043	1000
CommandBar	mount	8572	8537	1000
ContextualMenu	mount	18849	18677	1000
DefaultButton	mount	1168	1151	5000
DetailsRow	mount	3037	3047	5000
DetailsRowFast	mount	3076	3054	5000
DetailsRowNoStyles	mount	2845	2883	5000
Dialog	mount	3351	3405	1000
DocumentCardTitle	mount	453	452	1000
Dropdown	mount	2789	2755	5000
FocusTrapZone	mount	1662	1682	5000
FocusZone	mount	1597	1603	5000
GroupedList	mount	50696	66197	2
GroupedList	virtual-rerender	24576	24604	2
GroupedList	virtual-rerender-with-unmount	75930	76759	2
GroupedListV2	mount	454	440	2
GroupedListV2	virtual-rerender	430	429	2
GroupedListV2	virtual-rerender-with-unmount	453	435	2
IconButton	mount	1609	1588	5000
Label	mount	580	581	5000
Layer	mount	3724	3725	5000
Link	mount	651	650	5000
MenuButton	mount	1396	1428	5000
MessageBar	mount	28228	28372	5000
Nav	mount	2728	2766	1000
OverflowSet	mount	1141	1131	5000
Panel	mount	2153	2148	1000
Persona	mount	1105	1098	1000
Pivot	mount	1356	1373	1000
PrimaryButton	mount	1289	1264	5000
Rating	mount	5879	5934	5000
SearchBox	mount	1284	1275	5000
Shimmer	mount	2485	2475	5000
Slider	mount	1807	1780	5000
SpinButton	mount	3977	3920	5000
Spinner	mount	654	647	5000
SplitButton	mount	2710	2712	5000
Stack	mount	674	678	5000
StackWithIntrinsicChildren	mount	1263	1253	5000
StackWithTextChildren	mount	3406	3357	5000
SwatchColorPicker	mount	8360	8394	5000
TagPicker	mount	2148	2151	5000
Text	mount	627	641	5000
TextField	mount	1351	1341	5000
ThemeProvider	mount	1226	1253	5000
ThemeProvider	virtual-rerender	898	884	5000
ThemeProvider	virtual-rerender-with-unmount	1840	1866	5000
Toggle	mount	910	908	5000
buttonNative	mount	405	417	5000

fabricteam · 2023-03-16T00:31:36Z

🕵 fluentuiv8 No visual regressions between this PR and main

packages/react-components/react-conformance-griffel/package.json

TristanWatanabe · 2023-03-17T14:12:16Z

@microsoft/xc-uxe @Mitch-At-Work can i please get a review on this? :)

Mitch-At-Work

React-virtualizer change and changelog are correct (pre-release)

TristanWatanabe added 7 commits March 9, 2023 17:36

fix: add node field to package json exports map

df304c9

test: update tests

ae95952

chore: update PackageJson typings to include node in exports

e171193

nit: refactor

5b9d3d5

Merge branch 'master' into add-node-field-to-export-map

a3c0cbb

chore: run migrate-converged generator to add node field to exports map

8602ce6

Change Files

0a1c427

TristanWatanabe self-assigned this Mar 9, 2023

github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 9, 2023

TristanWatanabe added 4 commits March 15, 2023 05:29

Merge branch 'master' into add-node-field-to-v9-pkgs

823fb8e

Change Files for card and skeleton

6338161

Merge branch 'master' into add-node-field-to-v9-pkgs

644adfe

Merge branch 'master' into add-node-field-to-v9-pkgs

f067acd

msft-fluent-ui-bot added the Area: Build System label Mar 15, 2023

TristanWatanabe changed the title ~~chore: run migrate-converged-pkg generator to add node field to package.json exports map~~ chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map Mar 16, 2023

TristanWatanabe marked this pull request as ready for review March 16, 2023 01:44

TristanWatanabe requested review from a team and GeoffCoxMSFT as code owners March 16, 2023 01:44

TristanWatanabe requested review from a team, Mitch-At-Work, behowell, chpalac, khmakoto, ling1726, micahgodbolt, smhigley, sopranopillow, spmonahan and tomi-msft as code owners March 16, 2023 01:44

layershifter approved these changes Mar 16, 2023

View reviewed changes

spmonahan approved these changes Mar 16, 2023

View reviewed changes

packages/react-components/react-conformance-griffel/package.json Show resolved Hide resolved

Hotell approved these changes Mar 17, 2023

View reviewed changes

Mitch-At-Work approved these changes Mar 17, 2023

View reviewed changes

TristanWatanabe merged commit ead1c6d into microsoft:master Mar 17, 2023

TristanWatanabe deleted the add-node-field-to-v9-pkgs branch March 17, 2023 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map #27154

chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map #27154

Uh oh!

TristanWatanabe commented Mar 9, 2023 •

edited

Loading

Uh oh!

size-auditor bot commented Mar 10, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 10, 2023

Uh oh!

fabricteam commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 10, 2023 •

edited

Loading

Uh oh!

fabricteam commented Mar 16, 2023

Uh oh!

Uh oh!

TristanWatanabe commented Mar 17, 2023 •

edited

Loading

Uh oh!

Mitch-At-Work left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map #27154

chore (v9) : run migrate-converged-pkg generator to add node field to package.json exports map #27154

Uh oh!

Conversation

TristanWatanabe commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue(s)

Uh oh!

size-auditor bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Mar 10, 2023

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Mar 16, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

Uh oh!

TristanWatanabe commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mitch-At-Work left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TristanWatanabe commented Mar 9, 2023 •

edited

Loading

size-auditor bot commented Mar 10, 2023 •

edited

Loading

codesandbox-ci bot commented Mar 10, 2023 •

edited

Loading

fabricteam commented Mar 10, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Mar 10, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Mar 10, 2023 •

edited

Loading

fabricteam commented Mar 10, 2023 •

edited

Loading

fabricteam commented Mar 10, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

TristanWatanabe commented Mar 17, 2023 •

edited

Loading