Skip to content

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Mar 2, 2023

Changes:

Related Issue(s)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 191245b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 27c3cfe8a95bd26541c7c47ad2fd7fbc8ea332df (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1584 1550 5000
Button mount 1148 1125 5000
Field mount 2417 2387 5000
FluentProvider mount 1961 1917 5000
FluentProviderWithTheme mount 732 740 10
FluentProviderWithTheme virtual-rerender 695 697 10
FluentProviderWithTheme virtual-rerender-with-unmount 727 734 10
InfoButton mount 666 657 5000
MakeStyles mount 2227 2202 50000
Persona mount 3517 3435 5000
SpinButton mount 2842 2802 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.194 kB
1.314 kB
react-accordion
Accordion (including children components)
85.876 kB
26.019 kB
react-alert
Alert
90.221 kB
22.094 kB
react-avatar
Avatar
51.192 kB
14.043 kB
react-avatar
AvatarGroup
15.42 kB
6.167 kB
react-avatar
AvatarGroupItem
67.414 kB
18.551 kB
react-badge
Badge
23.113 kB
7.069 kB
react-badge
CounterBadge
24.002 kB
7.374 kB
react-badge
PresenceBadge
25.438 kB
7.254 kB
react-button
Button
39.644 kB
9.941 kB
react-button
CompoundButton
46.826 kB
11.411 kB
react-button
MenuButton
44.327 kB
11.265 kB
react-button
SplitButton
52.877 kB
12.872 kB
react-button
ToggleButton
58.013 kB
11.859 kB
react-card
Card - All
83.548 kB
23.894 kB
react-card
Card
78.317 kB
22.433 kB
react-card
CardFooter
9.045 kB
3.806 kB
react-card
CardHeader
10.984 kB
4.509 kB
react-card
CardPreview
9.852 kB
4.159 kB
react-checkbox
Checkbox
33.091 kB
10.319 kB
react-checkbox
CheckboxField
39.996 kB
12.206 kB
react-combobox
Combobox (including child components)
85.509 kB
27.437 kB
react-combobox
ComboboxField
81.926 kB
27.213 kB
react-combobox
Dropdown (including child components)
84.196 kB
27.191 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.061 kB
18.105 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
205.522 kB
57.033 kB
react-components
react-components: FluentProvider & webLightTheme
37.891 kB
12.039 kB
react-dialog
Dialog (including children components)
89.808 kB
26.701 kB
react-divider
Divider
17.11 kB
6.18 kB
react-field
Field
17.673 kB
6.543 kB
react-image
Image
11.259 kB
4.473 kB
react-infobutton
InfoButton
127.411 kB
38.824 kB
react-input
Input
22.94 kB
7.214 kB
react-input
InputField
32.819 kB
10.111 kB
react-label
Label
9.822 kB
4.066 kB
react-link
Link
12.306 kB
5.073 kB
react-menu
Menu (including children components)
127.102 kB
38.881 kB
react-menu
Menu (including selectable components)
130.171 kB
39.399 kB
react-overflow
hooks only
11.214 kB
4.271 kB
react-persona
Persona
58.207 kB
15.986 kB
react-popover
Popover
114.483 kB
35.249 kB
react-portal
Portal
11.377 kB
4.179 kB
react-portal-compat
PortalCompatProvider
6.324 kB
2.129 kB
react-positioning
usePositioning
23.791 kB
8.73 kB
react-progress
ProgressBar
13.59 kB
5.24 kB
react-progress
ProgressField
23.885 kB
8.385 kB
react-provider
FluentProvider
19.958 kB
6.838 kB
react-radio
Radio
32.676 kB
10.616 kB
react-radio
RadioGroup
14.885 kB
5.933 kB
react-radio
RadioGroupField
24.963 kB
9.07 kB
react-select
Select
24.145 kB
8.271 kB
react-select
SelectField
33.384 kB
10.779 kB
react-slider
Slider
33.091 kB
10.555 kB
react-slider
SliderField
42.922 kB
13.465 kB
react-spinbutton
SpinButton
32.83 kB
9.864 kB
react-spinbutton
SpinButtonField
41.766 kB
12.254 kB
react-spinner
Spinner
20.62 kB
6.682 kB
react-switch
Switch
28.225 kB
8.755 kB
react-switch
SwitchField
35.01 kB
10.655 kB
react-table
DataGrid
144.785 kB
39.447 kB
react-table
Table (Primitives only)
43.776 kB
12.063 kB
react-table
Table as DataGrid
134.4 kB
34.514 kB
react-table
Table (Selection only)
82.316 kB
20.576 kB
react-table
Table (Sort only)
81.637 kB
20.386 kB
react-text
Text - Default
12.261 kB
4.819 kB
react-text
Text - Wrappers
15.571 kB
5.23 kB
react-textarea
Textarea
26.336 kB
8.585 kB
react-textarea
TextareaField
36.537 kB
11.504 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
30.908 kB
6.714 kB
react-theme
Teams: Light theme
17.776 kB
5.141 kB
react-tooltip
Tooltip
46.328 kB
16.212 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 27c3cfe8a95bd26541c7c47ad2fd7fbc8ea332df

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1372 1400 5000
Breadcrumb mount 3462 3396 1000
Checkbox mount 3058 3053 5000
CheckboxBase mount 2754 2723 5000
ChoiceGroup mount 5109 5173 5000
ComboBox mount 1474 1459 1000
CommandBar mount 11101 11110 1000
ContextualMenu mount 16053 15748 1000
DefaultButton mount 1605 1616 5000
DetailsRow mount 3970 4036 5000
DetailsRowFast mount 4034 4087 5000
DetailsRowNoStyles mount 3892 3865 5000
Dialog mount 3634 3640 1000
DocumentCardTitle mount 660 658 1000
Dropdown mount 3740 3749 5000
FocusTrapZone mount 2335 2356 5000
FocusZone mount 2298 2294 5000
GroupedList mount 59293 65425 2
GroupedList virtual-rerender 28069 28182 2
GroupedList virtual-rerender-with-unmount 105574 105544 2
GroupedListV2 mount 640 655 2
GroupedListV2 virtual-rerender 622 646 2
GroupedListV2 virtual-rerender-with-unmount 659 651 2
IconButton mount 2220 2217 5000
Label mount 860 849 5000
Layer mount 5025 5015 5000
Link mount 953 977 5000
MenuButton mount 1928 1927 5000
MessageBar mount 2670 2749 5000
Nav mount 3827 3813 1000
OverflowSet mount 1570 1561 5000
Panel mount 2962 2937 1000
Persona mount 1532 1486 1000
Pivot mount 1908 1930 1000
PrimaryButton mount 1776 1800 5000
Rating mount 8085 8181 5000
SearchBox mount 1771 1783 5000
Shimmer mount 3276 3311 5000
Slider mount 2480 2433 5000
SpinButton mount 5414 5430 5000
Spinner mount 929 925 5000
SplitButton mount 3646 3570 5000
Stack mount 962 952 5000
StackWithIntrinsicChildren mount 2647 2644 5000
StackWithTextChildren mount 5495 5495 5000
SwatchColorPicker mount 11993 11992 5000
TagPicker mount 3015 3008 5000
TeachingBubble mount 95655 96249 5000
Text mount 925 915 5000
TextField mount 1831 1818 5000
ThemeProvider mount 1752 1770 5000
ThemeProvider virtual-rerender 1264 1243 5000
ThemeProvider virtual-rerender-with-unmount 2515 2501 5000
Toggle mount 1316 1280 5000
buttonNative mount 636 636 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review March 2, 2023 23:26
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner March 2, 2023 23:26
@TristanWatanabe
Copy link
Member Author

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TristanWatanabe TristanWatanabe merged commit d940979 into microsoft:master Mar 6, 2023
@TristanWatanabe TristanWatanabe deleted the cleanup-vrt-yaml-files branch March 6, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove shouldBuildstorybookaddon from template for VR Tests pipeline

4 participants