-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(VRT Pipelines): remove unneeded variables from yml files #27040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(VRT Pipelines): remove unneeded variables from yml files #27040
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 191245b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 27c3cfe8a95bd26541c7c47ad2fd7fbc8ea332df (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1584 | 1550 | 5000 | |
| Button | mount | 1148 | 1125 | 5000 | |
| Field | mount | 2417 | 2387 | 5000 | |
| FluentProvider | mount | 1961 | 1917 | 5000 | |
| FluentProviderWithTheme | mount | 732 | 740 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 695 | 697 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 727 | 734 | 10 | |
| InfoButton | mount | 666 | 657 | 5000 | |
| MakeStyles | mount | 2227 | 2202 | 50000 | |
| Persona | mount | 3517 | 3435 | 5000 | |
| SpinButton | mount | 2842 | 2802 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1372 | 1400 | 5000 | |
| Breadcrumb | mount | 3462 | 3396 | 1000 | |
| Checkbox | mount | 3058 | 3053 | 5000 | |
| CheckboxBase | mount | 2754 | 2723 | 5000 | |
| ChoiceGroup | mount | 5109 | 5173 | 5000 | |
| ComboBox | mount | 1474 | 1459 | 1000 | |
| CommandBar | mount | 11101 | 11110 | 1000 | |
| ContextualMenu | mount | 16053 | 15748 | 1000 | |
| DefaultButton | mount | 1605 | 1616 | 5000 | |
| DetailsRow | mount | 3970 | 4036 | 5000 | |
| DetailsRowFast | mount | 4034 | 4087 | 5000 | |
| DetailsRowNoStyles | mount | 3892 | 3865 | 5000 | |
| Dialog | mount | 3634 | 3640 | 1000 | |
| DocumentCardTitle | mount | 660 | 658 | 1000 | |
| Dropdown | mount | 3740 | 3749 | 5000 | |
| FocusTrapZone | mount | 2335 | 2356 | 5000 | |
| FocusZone | mount | 2298 | 2294 | 5000 | |
| GroupedList | mount | 59293 | 65425 | 2 | |
| GroupedList | virtual-rerender | 28069 | 28182 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 105574 | 105544 | 2 | |
| GroupedListV2 | mount | 640 | 655 | 2 | |
| GroupedListV2 | virtual-rerender | 622 | 646 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 659 | 651 | 2 | |
| IconButton | mount | 2220 | 2217 | 5000 | |
| Label | mount | 860 | 849 | 5000 | |
| Layer | mount | 5025 | 5015 | 5000 | |
| Link | mount | 953 | 977 | 5000 | |
| MenuButton | mount | 1928 | 1927 | 5000 | |
| MessageBar | mount | 2670 | 2749 | 5000 | |
| Nav | mount | 3827 | 3813 | 1000 | |
| OverflowSet | mount | 1570 | 1561 | 5000 | |
| Panel | mount | 2962 | 2937 | 1000 | |
| Persona | mount | 1532 | 1486 | 1000 | |
| Pivot | mount | 1908 | 1930 | 1000 | |
| PrimaryButton | mount | 1776 | 1800 | 5000 | |
| Rating | mount | 8085 | 8181 | 5000 | |
| SearchBox | mount | 1771 | 1783 | 5000 | |
| Shimmer | mount | 3276 | 3311 | 5000 | |
| Slider | mount | 2480 | 2433 | 5000 | |
| SpinButton | mount | 5414 | 5430 | 5000 | |
| Spinner | mount | 929 | 925 | 5000 | |
| SplitButton | mount | 3646 | 3570 | 5000 | |
| Stack | mount | 962 | 952 | 5000 | |
| StackWithIntrinsicChildren | mount | 2647 | 2644 | 5000 | |
| StackWithTextChildren | mount | 5495 | 5495 | 5000 | |
| SwatchColorPicker | mount | 11993 | 11992 | 5000 | |
| TagPicker | mount | 3015 | 3008 | 5000 | |
| TeachingBubble | mount | 95655 | 96249 | 5000 | |
| Text | mount | 925 | 915 | 5000 | |
| TextField | mount | 1831 | 1818 | 5000 | |
| ThemeProvider | mount | 1752 | 1770 | 5000 | |
| ThemeProvider | virtual-rerender | 1264 | 1243 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2515 | 2501 | 5000 | |
| Toggle | mount | 1316 | 1280 | 5000 | |
| buttonNative | mount | 636 | 636 | 5000 |
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Changes:
shouldBuildStorybookAddonandshouldBuildNorthstarvariables from .yml files as the changes in feat(scripts-storybook): unify workspace addon loading for dev and prod builds #27006 makes them unnecessary.Related Issue(s)