Skip to content

Combobox: Fix cursor jumping to the end of input #26931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 4 commits into from
Feb 21, 2023
Merged

Combobox: Fix cursor jumping to the end of input #26931

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4de29b
Combobox: if value is controlled, we should not update state
micahgodbolt Feb 21, 2023
5d67da2
changefile
micahgodbolt Feb 21, 2023
3af8f26
Update packages/react/src/components/Autofill/Autofill.tsx
micahgodbolt Feb 21, 2023
457e08a
Merge branch 'master' into combobox-jump-fix
micahgodbolt Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-894d0bed-f8c8-4b12-a243-6a8d22912afe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
micahgodbolt marked this conversation as resolved.
"type": "minor",
"comment": "Fix: Combobox if value is controlled, we should not update state",
"packageName": "@fluentui/react",
"email": "mgodbolt@microsoft.com",
"dependentChangeType": "patch"
}
8 changes: 6 additions & 2 deletions packages/react/src/components/Autofill/Autofill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,16 @@ export class Autofill extends React.Component<IAutofillProps, IAutofillState> im
}

// eslint-disable-next-line deprecation/deprecation
const { onInputChange, onInputValueChange } = this.props;
const { onInputChange, onInputValueChange, updateValueInWillReceiveProps } = this.props;
if (onInputChange) {
newValue = onInputChange?.(newValue, composing) || '';
}

this.setState({ inputValue: newValue }, () => onInputValueChange?.(newValue, composing));
// if value is controlled, then we should not update the value in state
Comment thread
micahgodbolt marked this conversation as resolved.
Outdated
// https://github.com/microsoft/fluentui/issues/18499
updateValueInWillReceiveProps
? onInputValueChange?.(newValue, composing)
: this.setState({ inputValue: newValue }, () => onInputValueChange?.(newValue, composing));
};

private _getDisplayValue(): string {
Expand Down