revert: rollback List rendering change #26896
Merged
+23
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oft#25331)" This rendering change caused layout issues in TilesList and a performance regression for a partner. This reverts commit a180b67.
ThomasMichon
approved these changes
Feb 17, 2023
behowell
reviewed
Feb 17, 2023
Asset size changes
Baseline commit: 3a039d91103f4f2554a5b81dad45e86bb4fd8f71 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 972eee2:
|
fabricteam
reviewed
Feb 17, 2023
Collaborator
📊 Bundle size report🤖 This report was generated against 3a039d91103f4f2554a5b81dad45e86bb4fd8f71 |
behowell
approved these changes
Feb 17, 2023
Contributor
behowell
left a comment
behowell
left a comment
There was a problem hiding this comment.
Could you add links to the PR and bug this is reverting in the PR description?
khmakoto
approved these changes
Feb 17, 2023
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| GroupedList | mount | 1791 | 52686 | 2 | Possible regression |
| GroupedList | virtual-rerender | 1088 | 22447 | 2 | Possible regression |
| GroupedList | virtual-rerender-with-unmount | 1586 | 81231 | 2 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1194 | 1190 | 5000 | |
| Breadcrumb | mount | 2825 | 2817 | 1000 | |
| Checkbox | mount | 2615 | 2634 | 5000 | |
| CheckboxBase | mount | 2370 | 2393 | 5000 | |
| ChoiceGroup | mount | 4286 | 4281 | 5000 | |
| ComboBox | mount | 1167 | 1179 | 1000 | |
| CommandBar | mount | 9314 | 9275 | 1000 | |
| ContextualMenu | mount | 12356 | 12600 | 1000 | |
| DefaultButton | mount | 1359 | 1352 | 5000 | |
| DetailsRow | mount | 3285 | 3256 | 5000 | |
| DetailsRowFast | mount | 3269 | 3278 | 5000 | |
| DetailsRowNoStyles | mount | 3135 | 3106 | 5000 | |
| Dialog | mount | 2935 | 2977 | 1000 | |
| DocumentCardTitle | mount | 585 | 588 | 1000 | |
| Dropdown | mount | 3146 | 3143 | 5000 | |
| FocusTrapZone | mount | 1981 | 1967 | 5000 | |
| FocusZone | mount | 1961 | 1959 | 5000 | |
| GroupedList | mount | 1791 | 52686 | 2 | Possible regression |
| GroupedList | virtual-rerender | 1088 | 22447 | 2 | Possible regression |
| GroupedList | virtual-rerender-with-unmount | 1586 | 81231 | 2 | Possible regression |
| GroupedListV2 | mount | 558 | 561 | 2 | |
| GroupedListV2 | virtual-rerender | 547 | 542 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 559 | 544 | 2 | |
| IconButton | mount | 1786 | 1802 | 5000 | |
| Label | mount | 751 | 740 | 5000 | |
| Layer | mount | 4161 | 4207 | 5000 | |
| Link | mount | 861 | 852 | 5000 | |
| MenuButton | mount | 1598 | 1604 | 5000 | |
| MessageBar | mount | 2334 | 2295 | 5000 | |
| Nav | mount | 3086 | 3055 | 1000 | |
| OverflowSet | mount | 1408 | 1398 | 5000 | |
| Panel | mount | 2505 | 2476 | 1000 | |
| Persona | mount | 1285 | 1303 | 1000 | |
| Pivot | mount | 1511 | 1528 | 1000 | |
| PrimaryButton | mount | 1489 | 1526 | 5000 | |
| Rating | mount | 6876 | 6968 | 5000 | |
| SearchBox | mount | 1485 | 1502 | 5000 | |
| Shimmer | mount | 2953 | 2961 | 5000 | |
| Slider | mount | 2112 | 2113 | 5000 | |
| SpinButton | mount | 4296 | 4325 | 5000 | |
| Spinner | mount | 830 | 831 | 5000 | |
| SplitButton | mount | 2872 | 2847 | 5000 | |
| Stack | mount | 862 | 871 | 5000 | |
| StackWithIntrinsicChildren | mount | 2222 | 2254 | 5000 | |
| StackWithTextChildren | mount | 4918 | 4940 | 5000 | |
| SwatchColorPicker | mount | 9507 | 9492 | 5000 | |
| TagPicker | mount | 2314 | 2337 | 5000 | |
| TeachingBubble | mount | 76321 | 76852 | 5000 | |
| Text | mount | 818 | 821 | 5000 | |
| TextField | mount | 1533 | 1571 | 5000 | |
| ThemeProvider | mount | 1462 | 1472 | 5000 | |
| ThemeProvider | virtual-rerender | 1131 | 1146 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2005 | 1994 | 5000 | |
| Toggle | mount | 1126 | 1158 | 5000 | |
| buttonNative | mount | 540 | 524 | 5000 |
This state was added in the change being reverted. Since this interface is exported it's part of the public API it must be maintained to avoid a breaking change. This state is currently not used but will be used when the feature being reverted is re-implemented.
Contributor
Author
|
This was re-implemented as an opt-in feature in #27002 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Change to List rendering behavior lead to rendering issues in consuming controls like
TilesList.Reverts this PR: #25331
Which is the fix for this issue: #23925
New Behavior
Rollback rendering to previous behavior.
Related issues