Skip to content

removed disabled property from Label #26658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layershifter merged 1 commit into from
Feb 5, 2023
Merged

removed disabled property from Label #26658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-components/react-input/stories/Input/InputDisabled.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ export const Disabled = () => {

return (
<div className={styles.root}>
<Label disabled htmlFor={inputId}>
Disabled input
</Label>
<Label htmlFor={inputId}>Disabled input</Label>
<Input disabled id={inputId} defaultValue="disabled value" />
</div>
);
Expand Down
4 changes: 1 addition & 3 deletions packages/react-components/react-radio/stories/RadioGroup/RadioGroupDisabled.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ export const Disabled = () => {
const labelId = useId('label');
return (
<div className={styles.field}>
<Label id={labelId} disabled>
Favorite Fruit
</Label>
<Label id={labelId}>Favorite Fruit</Label>
<RadioGroup defaultValue="apple" disabled aria-labelledby={labelId}>
<Radio value="apple" label="Apple" />
<Radio value="pear" label="Pear" />
Expand Down