Skip to content

fix: Using correct icon and color for away + out-of-office PresenceBadge #26655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khmakoto merged 3 commits into from
Feb 4, 2023
Merged

fix: Using correct icon and color for away + out-of-office PresenceBadge #26655

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f9da4c
fix: Using correct icon and color for away + out-of-office PresenceBa…
Feb 3, 2023
4896df6
Adding change file.
Feb 3, 2023
bcf0bbe
Getting rid of unnecessary style.
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-badge-1d02e00e-35d1-4d9a-8f0e-9a522c35bd8d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Feb 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1830 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
PresenceBadge Converged - OOF status.default - RTL.chromium.png 31 Changed
PresenceBadge Converged - OOF status.default.chromium.png 31 Changed

"type": "patch",
"comment": "fix: Using correct icon and color for away + out-of-office PresenceBadge.",
"packageName": "@fluentui/react-badge",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-badge/src/components/PresenceBadge/usePresenceBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const iconMap = (status: PresenceBadgeState['status'], outOfOffice: boolean, siz
case 'available':
return outOfOffice ? presenceAvailableRegular[size] : presenceAvailableFilled[size];
case 'away':
return outOfOffice ? presenceOfflineRegular[size] : presenceAwayFilled[size];
return outOfOffice ? presenceOofRegular[size] : presenceAwayFilled[size];
case 'blocked':
return presenceBlockedRegular[size];
case 'busy':
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-badge/src/components/PresenceBadge/usePresenceBadgeStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const useStyles = makeStyles({
color: tokens.colorPaletteRedBackground3,
},
outOfOfficeAway: {
color: tokens.colorPaletteMarigoldBackground3,
color: tokens.colorPaletteBerryForeground3,
},

// Icons are not resizeable, and these sizes are currently missing
Expand Down