Skip to content

chore(react-infobutton): Making InfoButton's content focusable and update example's text #26596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 2 commits into from
Feb 3, 2023
Merged

chore(react-infobutton): Making InfoButton's content focusable and update example's text #26596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6561413
Making InfoButton's popover focusable and updating example's text
sopranopillow Feb 1, 2023
3bf70fa
change file
sopranopillow Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-infobutton-69f14ed0-88e3-4612-94cb-3734976c0c7e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "chore: Making the content focusable and updating example's text.",
"packageName": "@fluentui/react-infobutton",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-infobutton/src/components/InfoButton/useInfoButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const useInfoButton_unstable = (props: InfoButtonProps, ref: React.Ref<HT
required: true,
defaultProps: {
role: 'note',
tabIndex: -1,
},
}),
};
Expand Down
2 changes: 1 addition & 1 deletion ...ages/react-components/react-infobutton/stories/Infobutton/InfoButtonWithLabel.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const InfoButtonWithLabel = () => {
<InfoButton
id={infoButtonId}
aria-labelledby={`${labelId} ${infoButtonId}`}
content="Your username should have at least 6 characters."
content="Usernames offer a unique way to identify you and keep your account secure."
/>
</div>
<Input id={inputId} placeholder="Username" />
Expand Down