Skip to content

Conversation

@krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Dec 8, 2022

Cherry-pick of #24903 and #25978

@size-auditor
Copy link

size-auditor bot commented Dec 8, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8c26b4e2c34095aa7fdbf3dee180b52b553833dd (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 8, 2022

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 776 774 5000
Breadcrumb mount 34680 34654 5000
Checkbox mount 1279 1298 5000
CheckboxBase mount 1048 1064 5000
ChoiceGroup mount 4031 4040 5000
ComboBox mount 688 691 1000
CommandBar mount 6529 6519 1000
ContextualMenu mount 11109 11328 1000
DefaultButton mount 922 944 5000
DetailsRow mount 2959 2991 5000
DetailsRowFast mount 3012 3000 5000
DetailsRowNoStyles mount 2808 2796 5000
Dialog mount 1780 1759 1000
DocumentCardTitle mount 1606 1512 1000
Dropdown mount 2026 2015 5000
FocusTrapZone mount 1459 1404 5000
FocusZone mount 1498 1507 5000
IconButton mount 1375 1380 5000
Label mount 306 316 5000
Layer mount 1646 1629 5000
Link mount 403 407 5000
MenuButton mount 1205 1187 5000
MessageBar mount 1877 1802 5000
Nav mount 2616 2591 1000
OverflowSet mount 1186 1183 5000
Panel mount 1174 1157 1000
Persona mount 797 801 1000
Pivot mount 1123 1120 1000
PrimaryButton mount 1050 1051 5000
Rating mount 6654 6691 5000
SearchBox mount 1051 1063 5000
Shimmer mount 2289 2248 5000
Slider mount 1274 1275 5000
SpinButton mount 3906 3929 5000
Spinner mount 393 390 5000
SplitButton mount 2427 2433 5000
Stack mount 465 458 5000
StackWithIntrinsicChildren mount 1340 1352 5000
StackWithTextChildren mount 4270 4263 5000
SwatchColorPicker mount 8170 7968 5000
TagPicker mount 2122 2142 5000
TeachingBubble mount 41374 41358 5000
Text mount 393 404 5000
TextField mount 1132 1141 5000
Toggle mount 733 741 5000
button mount 89 90 5000

@krkshitij krkshitij marked this pull request as ready for review December 12, 2022 09:58
@krkshitij krkshitij requested a review from a team as a code owner December 12, 2022 09:58
{
"type": "patch",
"comment": "Fix wrong narration when legend selected",
"packageName": "@uifabric/charting",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I remember, doesn't this change depend on the change where you added active/highlighted legend states.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it was the other way around. #24563 depended on this change

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v7 No visual regressions between this PR and main

@krkshitij krkshitij merged commit 59383dc into microsoft:7.0 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants