UI updates to the Alert Component #25855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e79659c9cb202610bf5d1a38be6f44367e19d72c (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9e0951:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1306 | 1316 | 5000 | |
| Button | mount | 934 | 933 | 5000 | |
| FluentProvider | mount | 1594 | 1588 | 5000 | |
| FluentProviderWithTheme | mount | 624 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 602 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 626 | 620 | 10 | |
| MakeStyles | mount | 1933 | 1920 | 50000 | |
| Persona | mount | 3006 | 3009 | 5000 | |
| SpinButton | mount | 2606 | 2529 | 5000 |
marigome-msft
requested review from
a team,
behowell and
khmakoto
as code owners
spmonahan
reviewed
Dec 8, 2022
packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts
Outdated
Show resolved
Hide resolved
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
change/@fluentui-react-alert-8a5ecb73-4cf7-422d-9df6-e2c5d0cacffd.json
Outdated
Show resolved
Hide resolved
layershifter
requested changes
Dec 12, 2022
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Please rebase the branch as it contains unrelated changes to this PR 🙏
…to marigome/alert-changes
marigome-msft
force-pushed
the
marigome/alert-changes
branch
from
9ccc621 to
b7db16f
Compare
marigome-msft
requested review from
layershifter
and removed request for
behowell and
khmakoto
Contributor
Author
|
packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts
Show resolved
Hide resolved
packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts
Outdated
Show resolved
Hide resolved
Member
|
@marigome-msft it seems that this PR fixes #25722, can you please check? If so, please add |
…AlertStyles.ts Co-authored-by: Oleksandr Fediashov <[email protected]>
…ffd.json Co-authored-by: Oleksandr Fediashov <[email protected]>
layershifter
approved these changes
Dec 19, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore(react-field): migrate to new package structure (microsoft#25817) * fixed alert styling * yarn change * Revert "chore(react-field): migrate to new package structure (microsoft#25817)" This reverts commit 0d473c1. * ui fixes * update tokens * using px instead of rem * Update packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts Co-authored-by: Oleksandr Fediashov <[email protected]> * Update change/@fluentui-react-alert-8a5ecb73-4cf7-422d-9df6-e2c5d0cacffd.json Co-authored-by: Oleksandr Fediashov <[email protected]> * tabster * update changelog to follow changelog guidelines Co-authored-by: Oleksandr Fediashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Alert Component UI to match desired look in teams.
Previous Behavior
New Behavior
Fixes #25722