chore: move v0 ts config to root #25854

Hotell · 2022-11-30T22:43:33Z

New Behavior

to follow monorepo ts config root base configs approach, this moves northstar base tsconfig to root outside of scripts/
scripts/typescript is not used thus it is removed as part of this PR
v8 related tooling dependencies are removed from v0 (dep on scripts/just and unused api-extractor)
fix: react-builder now ships type declarations

Related Issue(s)

DustyTheBot · 2022-11-30T22:47:57Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 292372d

size-auditor · 2022-11-30T22:58:01Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 52c7b4dd09236e0ed18b39a6a45f57f362528471 (build)

codesandbox-ci · 2022-11-30T22:59:11Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 292372d:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-30T23:00:53Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1260	1283	5000
Button	mount	920	912	5000
FluentProvider	mount	1494	1502	5000
FluentProviderWithTheme	mount	577	585	10
FluentProviderWithTheme	virtual-rerender	540	552	10
FluentProviderWithTheme	virtual-rerender-with-unmount	579	577	10
MakeStyles	mount	1953	1950	50000
Persona	mount	2807	2782	5000
SpinButton	mount	2334	2318	5000

fabricteam · 2022-11-30T23:01:26Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-11-30T23:06:50Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.541 kB` `22.325 kB`
`react-card` Card	`72.485 kB` `20.913 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.629 kB` `25.167 kB`
`react-combobox` ComboboxField	`75.831 kB` `25.116 kB`
`react-combobox` Dropdown (including child components)	`77.876 kB` `25.104 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.067 kB` `52.466 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.298 kB` `35.438 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.794 kB` `36.361 kB`
`react-menu` Menu (including selectable components)	`120.863 kB` `36.895 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.042 kB` `32.021 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.868 kB` `7.432 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.074 kB` `14.752 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 52c7b4dd09236e0ed18b39a6a45f57f362528471}

fabricteam · 2022-11-30T23:07:35Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-11-30T23:08:11Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-11-30T23:17:10Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1177	1200	5000
Breadcrumb	mount	2784	2832	1000
Checkbox	mount	2628	2602	5000
CheckboxBase	mount	2354	2359	5000
ChoiceGroup	mount	4277	4287	5000
ComboBox	mount	1175	1168	1000
CommandBar	mount	9191	9699	1000
ContextualMenu	mount	10077	10064	1000
DefaultButton	mount	1344	1377	5000
DetailsRow	mount	3331	3300	5000
DetailsRowFast	mount	3381	3364	5000
DetailsRowNoStyles	mount	3258	3216	5000
Dialog	mount	2930	2976	1000
DocumentCardTitle	mount	572	582	1000
Dropdown	mount	3162	3185	5000
FocusTrapZone	mount	1927	1936	5000
FocusZone	mount	1953	1920	5000
GroupedList	mount	1837	2049	2
GroupedList	virtual-rerender	1092	1108	2
GroupedList	virtual-rerender-with-unmount	1610	1601	2
GroupedListV2	mount	571	555	2
GroupedListV2	virtual-rerender	538	552	2
GroupedListV2	virtual-rerender-with-unmount	558	569	2
IconButton	mount	1776	1805	5000
Label	mount	748	754	5000
Layer	mount	4203	4205	5000
Link	mount	843	868	5000
MenuButton	mount	1597	1604	5000
MessageBar	mount	2362	2316	5000
Nav	mount	3066	3045	1000
OverflowSet	mount	1408	1392	5000
Panel	mount	2522	2469	1000
Persona	mount	1283	1300	1000
Pivot	mount	1533	1524	1000
PrimaryButton	mount	1517	1498	5000
Rating	mount	7006	6871	5000
SearchBox	mount	1491	1493	5000
Shimmer	mount	2911	2892	5000
Slider	mount	2098	2098	5000
SpinButton	mount	4215	4341	5000
Spinner	mount	825	833	5000
SplitButton	mount	2842	2826	5000
Stack	mount	851	851	5000
StackWithIntrinsicChildren	mount	2266	2262	5000
StackWithTextChildren	mount	4941	4926	5000
SwatchColorPicker	mount	9408	9485	5000
TagPicker	mount	2434	2298	5000
TeachingBubble	mount	74243	75924	5000
Text	mount	802	828	5000
TextField	mount	1533	1559	5000
ThemeProvider	mount	1444	1439	5000
ThemeProvider	virtual-rerender	1141	1130	5000
ThemeProvider	virtual-rerender-with-unmount	1983	2019	5000
Toggle	mount	1139	1154	5000
buttonNative	mount	535	539	5000

Hotell · 2022-12-01T16:30:26Z

tsconfig.base.v0.json

+    "typeRoots": ["node_modules/@types", "./typings"],
+    "baseUrl": ".",
+    "paths": {
+      "@fluentui/a11y-testing": ["packages/a11y-testing/src/index.ts"],


explicit mappings to libraries only

fabricteam · 2022-12-21T15:25:02Z

🕵 FluentUI-v0 No visual regressions between this PR and main

* chore: move v0 ts config to root * chore(scripts): remove obsolete /typescript * chore: expand v0 aliases to include only libraries * chore: categorize v0 apps in workspace.json * test: fix ts errors in tests * chore: remove unused api-extractor configs from v0 * chore: remove scripts/tasks dependency (v8) from v0 * chore: remove v8 packages from v0 ts path aliases * fix(react-builder): ship type declaration in v0 react-builder * fix: remove typescript/ from solution config

msft-fluent-ui-bot assigned khmakoto Nov 30, 2022

Hotell changed the title ~~Hotell/v0/ts solution config~~ chore: move v0 ts config to root Nov 30, 2022

Hotell added Area: Build System Fluent UI react-northstar (v0) Work related to Fluent UI V0 labels Nov 30, 2022

Hotell unassigned khmakoto Nov 30, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 30, 2022

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 30, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 30, 2022

Hotell commented Dec 1, 2022

View reviewed changes

Hotell marked this pull request as ready for review December 1, 2022 16:33

Hotell requested review from a team as code owners December 1, 2022 16:33

Hotell force-pushed the hotell/v0/ts-solution-config branch 2 times, most recently from e1df160 to 523054e Compare December 2, 2022 09:11

micahgodbolt approved these changes Dec 2, 2022

View reviewed changes

ling1726 approved these changes Dec 5, 2022

View reviewed changes

Hotell added 5 commits December 21, 2022 14:58

chore: move v0 ts config to root

12505b2

chore(scripts): remove obsolete /typescript

2ca2aa5

chore: expand v0 aliases to include only libraries

e3d6ac7

chore: categorize v0 apps in workspace.json

2caf5fa

test: fix ts errors in tests

7243b39

Hotell added 5 commits December 21, 2022 14:58

chore: remove unused api-extractor configs from v0

7e5abe4

chore: remove scripts/tasks dependency (v8) from v0

bb28395

chore: remove v8 packages from v0 ts path aliases

a1c750b

fix(react-builder): ship type declaration in v0 react-builder

818a508

fix: remove typescript/ from solution config

292372d

Hotell force-pushed the hotell/v0/ts-solution-config branch from 523054e to 292372d Compare December 21, 2022 14:53

Hotell merged commit 70cc602 into microsoft:master Dec 21, 2022

Hotell deleted the hotell/v0/ts-solution-config branch December 21, 2022 16:05

Hotell mentioned this pull request Jan 24, 2023

chore(public-docsite-v9): enable build-less DX for storybook #26476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: move v0 ts config to root #25854

chore: move v0 ts config to root #25854

Uh oh!

Hotell commented Nov 30, 2022 •

edited

Loading

Uh oh!

DustyTheBot commented Nov 30, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Nov 30, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

Hotell Dec 1, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: move v0 ts config to root #25854

chore: move v0 ts config to root #25854

Uh oh!

Conversation

Hotell commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Related Issue(s)

Uh oh!

DustyTheBot commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Nov 30, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Hotell Dec 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabricteam commented Dec 21, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hotell commented Nov 30, 2022 •

edited

Loading

DustyTheBot commented Nov 30, 2022 •

edited

Loading

size-auditor bot commented Nov 30, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 30, 2022 •

edited

Loading

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 30, 2022 •

edited

Loading

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 30, 2022 •

edited

Loading

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Hotell Dec 1, 2022 •

edited

Loading