Skip to content

chore(react-field): migrate to new package structure #25817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristanWatanabe merged 2 commits into from
Nov 29, 2022
Merged

chore(react-field): migrate to new package structure #25817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aad73c9
chore: run migration generator
TristanWatanabe Nov 20, 2022
57ad0ee
Change File
TristanWatanabe Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-field-e41be758-df09-47c8-bd8f-4ddb5b61c2ad.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "chore: Migrate to new package structure.",
"packageName": "@fluentui/react-field",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions packages/react-components/react-field/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
bundle-size/
config/
coverage/
e2e/
docs/
etc/
node_modules/
src/
stories/
dist/types/
temp/
__fixtures__
Expand All @@ -16,7 +17,7 @@ __tests__
*.api.json
*.log
*.spec.*
*.stories.*
*.cy.*
*.test.*
*.yml

Expand Down
7 changes: 1 addition & 6 deletions packages/react-components/react-field/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@ const rootMain = require('../../../../.storybook/main');

module.exports = /** @type {Omit<import('../../../../.storybook/main'), 'typescript'|'babel'>} */ ({
...rootMain,
stories: [
...rootMain.stories,
'../src/**/*.stories.mdx',
'../src/stories/Field/index.stories.@(ts|tsx)',
Copy link
Member Author

@TristanWatanabe TristanWatanabe Nov 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is no longer necessary since all other Field component stories are no longer part of this package - https://github.com/microsoft/fluentui/pull/24426/files#r962066436

'../src/**/index.stories.@(ts|tsx)',
],
stories: [...rootMain.stories, '../stories/**/*.stories.mdx', '../stories/**/index.stories.@(ts|tsx)'],
addons: [...rootMain.addons],
webpackFinal: (config, options) => {
const localConfig = { ...rootMain.webpackFinal(config, options) };
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-field/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
"checkJs": true,
"types": ["static-assets", "environment", "storybook__addons"]
},
"include": ["../src/**/*.stories.ts", "../src/**/*.stories.tsx", "*.js"]
"include": ["../stories/**/*.stories.ts", "../stories/**/*.stories.tsx", "*.js"]
}
0 ...ages/react-components/react-field/Spec.md → ...react-components/react-field/docs/Spec.md
View file
Open in desktop
File renamed without changes.
0 ...rc/stories/Field/FieldDefault.stories.tsx → ...ld/stories/Field/FieldDefault.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...eld/src/stories/Field/FieldDescription.md → ...t-field/stories/Field/FieldDescription.md
View file
Open in desktop
File renamed without changes.
0 ...d/src/stories/Field/FieldHint.stories.tsx → ...field/stories/Field/FieldHint.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...stories/Field/FieldHorizontal.stories.tsx → ...stories/Field/FieldHorizontal.stories.tsx
View file
Open in desktop
File renamed without changes.
0 .../src/stories/Field/FieldLabel.stories.tsx → ...ield/stories/Field/FieldLabel.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...c/stories/Field/FieldRequired.stories.tsx → ...d/stories/Field/FieldRequired.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...d/src/stories/Field/FieldSize.stories.tsx → ...field/stories/Field/FieldSize.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...es/Field/FieldValidationState.stories.tsx → ...es/Field/FieldValidationState.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...field/src/stories/Field/index.stories.tsx → ...act-field/stories/Field/index.stories.tsx
View file
Open in desktop
File renamed without changes.
10 changes: 1 addition & 9 deletions packages/react-components/react-field/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": [
"./src/common/**",
"**/*.spec.ts",
"**/*.spec.tsx",
"**/*.test.ts",
"**/*.test.tsx",
"**/*.stories.ts",
"**/*.stories.tsx"
],
"exclude": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx", "**/*.stories.ts", "**/*.stories.tsx"],
"include": ["./src/**/*.ts", "./src/**/*.tsx"]
}