Skip to content

Conversation

@sunilsurana
Copy link
Member

Previous Behavior

The 3 stories related to avatar converged create minor noise in storywright tool which is alternative for screener.io
This happens only on chromium browser and not on firefox. The issue is being investigated playwright team.
Hence for sometime these stories are being disabled.

New Behavior

Screenshots for Avatar Converged active will not be captured

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 2d9a9f3147deea6d0c0a60747e1074faf47968c3

@size-auditor
Copy link

size-auditor bot commented Nov 23, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2d9a9f3147deea6d0c0a60747e1074faf47968c3 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 376ef95:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 3 screenshots

✅ There was 0 screenshots added, 3 screenshots removed, 1748 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 3 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 0 Removed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 0 Removed
Avatar Converged.size+active+shadow.normal.chromium.png 0 Removed

@sunilsurana sunilsurana merged commit 5ddd705 into microsoft:master Dec 1, 2022
@sunilsurana sunilsurana deleted the user/susurana/disable3story branch December 1, 2022 07:03
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Dec 1, 2022
* master:
  BREAKING: `useTable` renamed to `useTableFeatures` (microsoft#25797)
  chore: add retries for navigation in ssr-tests-v9 (microsoft#25844)
  fix: Cell actions should have correct background when row focused within (microsoft#25790)
  applying package updates
  Disable 3 Avatar Converged active stories (microsoft#25765)
  chore: introduce TS path aliases for improved DX in v8 (microsoft#25778)
  chore: prepare release react-northstar 0.65.0 (microsoft#25446)
  refactor(scripts): encapsulate v0 and v8 tooling within its domain boundaries (microsoft#25738)
  Support single point in area chart (microsoft#25842)
  chore: enable isolateModules in all v8 packages (microsoft#25774)
  chore: refactor styles for Button (microsoft#25216)
  feat: Improve docs for `DataGrid`, export as unstable (microsoft#25805)
  applying package updates
  fix: Allow data-selection-disabled to be respected by DetailsRow (microsoft#25836)
  docs(rfcs): Update recipes rfc with chosen option and add more details (microsoft#25823)
  chore(react-textarea): migrate to new package structure (microsoft#25820)
  chore(react-switch): migrate to new package structure (microsoft#25819)
  fix(react-avatar): AvatarGroup's pie layout places inline items correctly in rtl (microsoft#25822)
  chore: add few improvements to toolbar stories (microsoft#25635)
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants