Skip to content

fix(Button): Revert margin fix for Safari to fix Stack regression #25759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 3 commits into from
Nov 23, 2022
Merged

fix(Button): Revert margin fix for Safari to fix Stack regression #25759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83f740c
reverting margin fix for safari
sopranopillow Nov 22, 2022
d1279e8
change file
sopranopillow Nov 22, 2022
c724152
updating snapshots
sopranopillow Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-b1886c50-127e-4b1f-81c8-81013fd2c50a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Revert fix for margin added by safari.",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
16 changes: 0 additions & 16 deletions .../react-experiments/src/components/MicroFeedback/__snapshots__/MicroFeedback.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ exports[`MicroFeedback renders correctly with inline prop set 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -187,10 +183,6 @@ exports[`MicroFeedback renders correctly with inline prop set 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -359,10 +351,6 @@ exports[`MicroFeedback renders correctly with no props 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -491,10 +479,6 @@ exports[`MicroFeedback renders correctly with no props 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
56 changes: 0 additions & 56 deletions packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -167,10 +163,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -299,10 +291,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -409,10 +397,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -519,10 +503,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -629,10 +609,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -739,10 +715,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -847,10 +819,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -992,10 +960,6 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1164,10 +1128,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1297,10 +1257,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1649,10 +1605,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-weight: 400;
height: 100%;
line-height: 30px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1804,10 +1756,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1935,10 +1883,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
28 changes: 0 additions & 28 deletions ...nents/SelectedItemsList/SelectedPeopleList/__snapshots__/SelectedPeopleList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,7 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: -17px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -395,10 +392,6 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -587,10 +580,7 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: -17px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -910,10 +900,6 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1107,10 +1093,7 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: -17px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1430,10 +1413,6 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1622,10 +1601,7 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: -17px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1945,10 +1921,6 @@ Array [
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
7 changes: 0 additions & 7 deletions ...ponents/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,7 @@ exports[`UnifiedPeoplePicker renders correctly with selected and suggested items
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: -17px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -811,10 +808,6 @@ exports[`UnifiedPeoplePicker renders correctly with selected and suggested items
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
20 changes: 0 additions & 20 deletions packages/react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ exports[`Breadcrumb rendering renders correctly with custom overflow icon 1`] =
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1319,10 +1315,6 @@ exports[`Breadcrumb rendering renders correctly with maxDisplayedItems and overf
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1536,10 +1528,6 @@ exports[`Breadcrumb rendering renders correctly with maxDisplayedItems and overf
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1753,10 +1741,6 @@ exports[`Breadcrumb rendering renders correctly with overflow 1`] = `
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -2258,10 +2242,6 @@ exports[`Breadcrumb rendering renders correctly with overflow and overflowIndex
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down
4 changes: 1 addition & 3 deletions packages/react/src/components/Button/BaseButton.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const noOutline: IRawStyle = {

const iconStyle = (fontSize?: string | number): IRawStyle => {
return {
fontSize: fontSize,
fontSize,
margin: '0 4px',
height: '16px',
lineHeight: '16px',
Expand Down Expand Up @@ -48,8 +48,6 @@ export const getStyles = memoizeFunction(
boxSizing: 'border-box',
cursor: 'pointer',
display: 'inline-block',
// This removes the 2px margin Safari adds to all buttons
margin: 0,
padding: '0 16px',
textDecoration: 'none',
textAlign: 'center',
Expand Down
Loading