chore: Updating Pull Request Template #25683

khmakoto · 2022-11-15T21:35:25Z

PR Description

This PR updates the PR Template so that it reads ## Previous Behavior instead of ## Current Behavior when referring to the behavior that existed before the changes in the PR. This makes it less ambiguous as Current could mean the behavior before or after the PR depending on how it's used.

## PR Description This PR updates the PR Template so that it reads `## Previous Behavior` instead of `## Current Behavior` when referring to the behavior that existed before the changes in the PR. This makes it less ambiguous as `Current` could mean the behavior before or after the PR depending on how it's used.

size-auditor · 2022-11-15T21:48:50Z

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: fc94f09

Possible causes

The baseline build fc94f09 is broken
The Size Auditor run for the baseline build fc94f09 was not triggered

Recommendations

Please merge your branch for this Pull request with the latest master build and commit your changes once again

codesandbox-ci · 2022-11-15T21:50:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0b30dd:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-15T21:53:01Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1148	1267	5000
Button	mount	845	848	5000
FluentProvider	mount	1540	1502	5000
FluentProviderWithTheme	mount	576	564	10
FluentProviderWithTheme	virtual-rerender	531	527	10
FluentProviderWithTheme	virtual-rerender-with-unmount	555	629	10
MakeStyles	mount	1768	1837	50000
SpinButton	mount	2391	2305	5000

fabricteam · 2022-11-15T21:57:53Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	136	114	1.19:1
AlertMinimalPerf.default	220	190	1.16:1
GridMinimalPerf.default	276	240	1.15:1
TextMinimalPerf.default	280	246	1.14:1
RefMinimalPerf.default	178	159	1.12:1
ImageMinimalPerf.default	311	285	1.09:1
TextAreaMinimalPerf.default	383	356	1.08:1
TableMinimalPerf.default	333	313	1.06:1
AvatarMinimalPerf.default	158	151	1.05:1
CheckboxMinimalPerf.default	1684	1601	1.05:1
FormMinimalPerf.default	324	309	1.05:1
AccordionMinimalPerf.default	120	115	1.04:1
FlexMinimalPerf.default	235	227	1.04:1
LabelMinimalPerf.default	321	308	1.04:1
ListWith60ListItems.default	517	495	1.04:1
LoaderMinimalPerf.default	276	265	1.04:1
SkeletonMinimalPerf.default	291	279	1.04:1
StatusMinimalPerf.default	569	549	1.04:1
AttachmentMinimalPerf.default	121	118	1.03:1
AttachmentSlotsPerf.default	944	913	1.03:1
ChatMinimalPerf.default	606	589	1.03:1
ButtonMinimalPerf.default	136	133	1.02:1
CarouselMinimalPerf.default	382	373	1.02:1
ListMinimalPerf.default	424	414	1.02:1
PopupMinimalPerf.default	530	519	1.02:1
ProviderMinimalPerf.default	337	330	1.02:1
SegmentMinimalPerf.default	291	284	1.02:1
ToolbarMinimalPerf.default	772	758	1.02:1
TooltipMinimalPerf.default	1991	1943	1.02:1
AnimationMinimalPerf.default	437	432	1.01:1
BoxMinimalPerf.default	277	274	1.01:1
DatepickerMinimalPerf.default	4768	4739	1.01:1
DropdownMinimalPerf.default	2255	2236	1.01:1
ItemLayoutMinimalPerf.default	971	962	1.01:1
MenuButtonMinimalPerf.default	1414	1400	1.01:1
RosterPerf.default	1761	1735	1.01:1
ProviderMergeThemesPerf.default	1066	1054	1.01:1
ReactionMinimalPerf.default	308	306	1.01:1
SliderMinimalPerf.default	1326	1312	1.01:1
HeaderMinimalPerf.default	291	290	1:1
HeaderSlotsPerf.default	619	618	1:1
LayoutMinimalPerf.default	288	287	1:1
ListCommonPerf.default	512	513	1:1
ListNestedPerf.default	444	446	1:1
IconMinimalPerf.default	542	541	1:1
TreeMinimalPerf.default	664	666	1:1
ChatDuplicateMessagesPerf.default	213	215	0.99:1
ChatWithPopoverPerf.default	296	298	0.99:1
DividerMinimalPerf.default	292	294	0.99:1
PortalMinimalPerf.default	135	136	0.99:1
CustomToolbarPrototype.default	2207	2223	0.99:1
DropdownManyItemsPerf.default	529	541	0.98:1
RadioGroupMinimalPerf.default	358	364	0.98:1
SplitButtonMinimalPerf.default	3536	3607	0.98:1
CardMinimalPerf.default	409	423	0.97:1
MenuMinimalPerf.default	670	688	0.97:1
VideoMinimalPerf.default	566	583	0.97:1
ButtonOverridesMissPerf.default	1030	1078	0.96:1
EmbedMinimalPerf.default	2867	2990	0.96:1
InputMinimalPerf.default	889	934	0.95:1
DialogMinimalPerf.default	587	631	0.93:1
TableManyItemsPerf.default	1399	1530	0.91:1
ButtonSlotsPerf.default	411	456	0.9:1

fabricteam · 2022-11-15T21:57:56Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`86.891 kB` `21.708 kB`
`react-avatar` Avatar	`51.076 kB` `14.285 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`65.654 kB` `18.382 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`36.86 kB` `9.913 kB`
`react-button` CompoundButton	`43.885 kB` `11.131 kB`
`react-button` MenuButton	`41.537 kB` `11.187 kB`
`react-button` SplitButton	`48.983 kB` `12.588 kB`
`react-button` ToggleButton	`52.685 kB` `11.415 kB`
`react-card` Card - All	`71.873 kB` `20.936 kB`
`react-card` Card	`67.651 kB` `19.892 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`9.792 kB` `3.995 kB`
`react-card` CardPreview	`8.718 kB` `3.674 kB`
`react-combobox` Combobox (including child components)	`78.086 kB` `24.988 kB`
`react-combobox` Dropdown (including child components)	`77.373 kB` `24.891 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.951 kB` `17.675 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`190.427 kB` `53.087 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.456 kB` `11.029 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`117.938 kB` `35.399 kB`
`react-input` Input	`24.122 kB` `7.889 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.61 kB` `36.287 kB`
`react-menu` Menu (including selectable components)	`120.679 kB` `36.82 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.131 kB` `15.951 kB`
`react-popover` Popover	`103.682 kB` `31.867 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.536 kB` `5.107 kB`
`react-provider` FluentProvider	`15.817 kB` `5.905 kB`
`react-radio` Radio	`36.446 kB` `12.123 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.438 kB` `8.018 kB`
`react-slider` Slider	`32.118 kB` `10.192 kB`
`react-spinbutton` SpinButton	`44.43 kB` `12.812 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.453 kB` `10.581 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.697 kB` `8.328 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against fc94f09d58f1bb48bb8bdcc562d9a8fc5b801e98}

fabricteam · 2022-11-15T22:12:24Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1074	1828	5000	Possible regression
Label	mount	733	1299	5000	Possible regression
Layer	mount	5960	4650	5000	Possible regression
Text	mount	1151	790	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1074	1828	5000	Possible regression
Breadcrumb	mount	3056	2863	1000
Checkbox	mount	2600	2526	5000
CheckboxBase	mount	2177	2322	5000
ChoiceGroup	mount	4288	5867	5000
ComboBox	mount	1232	1224	1000
CommandBar	mount	11525	9934	1000
ContextualMenu	mount	13302	13166	1000
DefaultButton	mount	1374	1374	5000
DetailsRow	mount	3500	3602	5000
DetailsRowFast	mount	3614	3436	5000
DetailsRowNoStyles	mount	3480	3538	5000
Dialog	mount	3175	3169	1000
DocumentCardTitle	mount	581	600	1000
Dropdown	mount	3246	3262	5000
FocusTrapZone	mount	2043	1998	5000
FocusZone	mount	1979	2006	5000
GroupedList	mount	1969	2236	2
GroupedList	virtual-rerender	1137	1057	2
GroupedList	virtual-rerender-with-unmount	1726	1553	2
GroupedListV2	mount	571	588	2
GroupedListV2	virtual-rerender	536	569	2
GroupedListV2	virtual-rerender-with-unmount	593	584	2
IconButton	mount	1903	1844	5000
Label	mount	733	1299	5000	Possible regression
Layer	mount	5960	4650	5000	Possible regression
Link	mount	768	785	5000
MenuButton	mount	1709	1658	5000
MessageBar	mount	2349	2366	5000
Nav	mount	3277	3326	1000
OverflowSet	mount	1377	1334	5000
Panel	mount	2608	2644	1000
Persona	mount	1288	1319	1000
Pivot	mount	1639	1667	1000
PrimaryButton	mount	1537	1538	5000
Rating	mount	7002	7130	5000
SearchBox	mount	1534	1527	5000
Shimmer	mount	2875	2935	5000
Slider	mount	2090	2140	5000
SpinButton	mount	8758	4714	5000
Spinner	mount	798	786	5000
SplitButton	mount	2922	3122	5000
Stack	mount	846	830	5000
StackWithIntrinsicChildren	mount	2437	2475	5000
StackWithTextChildren	mount	4927	4791	5000
SwatchColorPicker	mount	10068	10584	5000
TagPicker	mount	2550	2642	5000
TeachingBubble	mount	104197	106106	5000
Text	mount	1151	790	5000	Possible regression
TextField	mount	1620	1574	5000
ThemeProvider	mount	1449	1545	5000
ThemeProvider	virtual-rerender	1088	1096	5000
ThemeProvider	virtual-rerender-with-unmount	2140	2126	5000
Toggle	mount	1120	1138	5000
buttonNative	mount	538	520	5000

behowell

Looks good to me.

And this is unrelated, but another minor change while you're here... would you mind adding a * in front of Fixes on line 27? That will make it into a bullet, but more helpfully, it'll cause GitHub to format it with the issue's full title instead of just the number.

* Fixes #

I can also make a separate PR if you'd prefer.

khmakoto · 2022-11-16T18:53:29Z

Looks good to me.

And this is unrelated, but another minor change while you're here... would you mind adding a * in front of Fixes on line 27? That will make it into a bullet, but more helpfully, it'll cause GitHub to format it with the issue's full title instead of just the number.

Fixes #
I can also make a separate PR if you'd prefer.

@behowell done!

khmakoto · 2022-11-17T18:13:05Z

/azp run

azure-pipelines · 2022-11-17T18:13:34Z

Azure Pipelines successfully started running 4 pipeline(s).

fabricteam · 2022-11-17T18:34:20Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-11-17T18:40:37Z

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1750 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference.

unknown 1 screenshots

Image Name	Diff(in Pixels)	Image Type
Avatar Converged.size+active+badge.normal.chromium.png	6	Changed

Hotell · 2022-11-18T10:13:06Z

next time it would be nice to get all teams consensus on changes that affect all teams and all contributors. Would you mind elaborate the pressing concern :) ?

Also regarding the bullet with Fixes seems odd. It also might break closing referenced issues 🥲.

Last but not least this template was based on common OSS practices.

khmakoto · 2022-11-18T20:17:30Z

@Hotell, I remember we had this conversation before in Teams a while ago and it was agreed to change from Current to Previous, but it was never done. As for the bullet with the "Fixes", I agree that could have waited.

* chore: Updating Pull Request Template ## PR Description This PR updates the PR Template so that it reads `## Previous Behavior` instead of `## Current Behavior` when referring to the behavior that existed before the changes in the PR. This makes it less ambiguous as `Current` could mean the behavior before or after the PR depending on how it's used. * Update PULL_REQUEST_TEMPLATE.md

behowell · 2022-11-18T21:43:11Z

@Hotell

Also regarding the bullet with Fixes seems odd. It also might break closing referenced issues 🥲.

Since this was my suggestion, I can confirm that it does not break closing referenced issues. I've been adding bullets to my PRs without any problems (e.g. #25497).

Can you elaborate on your comment that it seems odd? See my comment above for the reasoning behind it: #25683 (review)

Hotell · 2022-11-22T11:41:20Z

I can confirm that it does not break closing referenced issues

👍

Can you elaborate on your comment that it seems odd?

Not sure if this needs more elaboration ? -> "Also regarding the bullet with Fixes seems odd. It also might break closing referenced issues 🥲."

* chore: Updating Pull Request Template ## PR Description This PR updates the PR Template so that it reads `## Previous Behavior` instead of `## Current Behavior` when referring to the behavior that existed before the changes in the PR. This makes it less ambiguous as `Current` could mean the behavior before or after the PR depending on how it's used. * Update PULL_REQUEST_TEMPLATE.md

khmakoto requested a review from Hotell November 15, 2022 21:35

khmakoto self-assigned this Nov 15, 2022

khmakoto requested review from JustSlone and miroslavstastny November 15, 2022 21:35

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 15, 2022

khmakoto marked this pull request as ready for review November 15, 2022 22:29

smhigley approved these changes Nov 15, 2022

View reviewed changes

khmakoto enabled auto-merge (squash) November 15, 2022 22:37

sopranopillow approved these changes Nov 15, 2022

View reviewed changes

khmakoto closed this Nov 15, 2022

auto-merge was automatically disabled November 15, 2022 23:05
Pull request was closed

khmakoto reopened this Nov 15, 2022

khmakoto closed this Nov 16, 2022

khmakoto reopened this Nov 16, 2022

behowell approved these changes Nov 16, 2022

View reviewed changes

JustSlone approved these changes Nov 16, 2022

View reviewed changes

Update PULL_REQUEST_TEMPLATE.md

f0b30dd

khmakoto enabled auto-merge (squash) November 16, 2022 18:53

khmakoto merged commit 94e156b into master Nov 17, 2022

khmakoto deleted the updatingPullRequestTemplate branch November 17, 2022 19:23

chore: Updating Pull Request Template #25683

chore: Updating Pull Request Template #25683

Conversation

khmakoto commented Nov 15, 2022

PR Description

Uh oh!

size-auditor bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

behowell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khmakoto commented Nov 16, 2022

Uh oh!

khmakoto commented Nov 17, 2022

Uh oh!

azure-pipelines bot commented Nov 17, 2022

Uh oh!

fabricteam commented Nov 17, 2022

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 17, 2022

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

Uh oh!

Hotell commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khmakoto commented Nov 18, 2022

Uh oh!

behowell commented Nov 18, 2022

Uh oh!

Hotell commented Nov 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

size-auditor bot commented Nov 15, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 15, 2022 •

edited

Loading

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 15, 2022 •

edited

Loading

fabricteam commented Nov 15, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

behowell left a comment •

edited

Loading

Hotell commented Nov 18, 2022 •

edited

Loading

Hotell commented Nov 22, 2022 •

edited

Loading