Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 15, 2022

Current Behavior

After #25609, v9 packages that need to ship AMD will not ship it

New Behavior

v9 packages ship AMD if they have it setup

Related Issue(s)

Follows #25609

@Hotell Hotell force-pushed the hotell/build/api-generation/fix-copy-compiled branch from 6091ee4 to 59a8f58 Compare November 15, 2022 16:33
@Hotell Hotell changed the title Hotell/build/api generation/fix copy compiled fix(scripts): copy amd files for ts-solution projects if they exist Nov 15, 2022
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 15, 2022
@Hotell Hotell marked this pull request as ready for review November 15, 2022 16:34
@Hotell Hotell requested a review from a team as a code owner November 15, 2022 16:34
@Hotell Hotell enabled auto-merge (squash) November 15, 2022 16:35
@size-auditor
Copy link

size-auditor bot commented Nov 15, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 131d20e15d6c59dce2dcbbd8794b5ee75701a670 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59a8f58:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1692 1661 5000
Button mount 1176 1251 5000
FluentProvider mount 2035 1959 5000
FluentProviderWithTheme mount 727 722 10
FluentProviderWithTheme virtual-rerender 677 669 10
FluentProviderWithTheme virtual-rerender-with-unmount 723 730 10
MakeStyles mount 2319 2292 50000
SpinButton mount 3341 3335 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
86.996 kB
21.732 kB
react-avatar
Avatar
51.181 kB
14.31 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
65.759 kB
18.408 kB
react-badge
Badge
22.656 kB
7.225 kB
react-badge
CounterBadge
23.546 kB
7.508 kB
react-badge
PresenceBadge
24.106 kB
7.087 kB
react-button
Button
36.86 kB
9.913 kB
react-button
CompoundButton
43.885 kB
11.131 kB
react-button
MenuButton
41.537 kB
11.187 kB
react-button
SplitButton
48.983 kB
12.588 kB
react-button
ToggleButton
52.685 kB
11.415 kB
react-card
Card - All
71.873 kB
20.936 kB
react-card
Card
67.651 kB
19.892 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
9.792 kB
3.995 kB
react-card
CardPreview
8.718 kB
3.674 kB
react-combobox
Combobox (including child components)
78.086 kB
24.988 kB
react-combobox
Dropdown (including child components)
77.373 kB
24.891 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.951 kB
17.675 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.456 kB
11.029 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.938 kB
35.399 kB
react-input
Input
24.122 kB
7.889 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.61 kB
36.287 kB
react-menu
Menu (including selectable components)
120.679 kB
36.82 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
56.299 kB
15.708 kB
react-popover
Popover
103.682 kB
31.867 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.11 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.446 kB
12.123 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.438 kB
8.018 kB
react-slider
Slider
32.118 kB
10.192 kB
react-spinbutton
SpinButton
44.43 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.453 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.697 kB
8.328 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 131d20e15d6c59dce2dcbbd8794b5ee75701a670

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 211 162 1.3:1
AttachmentMinimalPerf.default 184 157 1.17:1
ChatWithPopoverPerf.default 448 388 1.15:1
BoxMinimalPerf.default 408 363 1.12:1
ListWith60ListItems.default 705 638 1.11:1
RefMinimalPerf.default 256 233 1.1:1
AttachmentSlotsPerf.default 1256 1165 1.08:1
ButtonMinimalPerf.default 190 177 1.07:1
ListCommonPerf.default 742 693 1.07:1
TreeMinimalPerf.default 900 850 1.06:1
HeaderSlotsPerf.default 874 835 1.05:1
LayoutMinimalPerf.default 403 383 1.05:1
RadioGroupMinimalPerf.default 495 470 1.05:1
StatusMinimalPerf.default 770 731 1.05:1
ToolbarMinimalPerf.default 1051 997 1.05:1
TableMinimalPerf.default 432 414 1.04:1
DropdownManyItemsPerf.default 782 757 1.03:1
FormMinimalPerf.default 434 420 1.03:1
HeaderMinimalPerf.default 392 380 1.03:1
LabelMinimalPerf.default 430 418 1.03:1
ListMinimalPerf.default 568 550 1.03:1
ListNestedPerf.default 623 607 1.03:1
MenuButtonMinimalPerf.default 1895 1832 1.03:1
SkeletonMinimalPerf.default 377 366 1.03:1
IconMinimalPerf.default 722 700 1.03:1
TextMinimalPerf.default 378 367 1.03:1
AccordionMinimalPerf.default 151 148 1.02:1
ButtonOverridesMissPerf.default 1444 1421 1.02:1
ChatDuplicateMessagesPerf.default 287 282 1.02:1
MenuMinimalPerf.default 926 909 1.02:1
ProviderMergeThemesPerf.default 1340 1308 1.02:1
SegmentMinimalPerf.default 375 366 1.02:1
TableManyItemsPerf.default 2137 2104 1.02:1
DividerMinimalPerf.default 401 397 1.01:1
GridMinimalPerf.default 378 373 1.01:1
RosterPerf.default 2355 2341 1.01:1
PopupMinimalPerf.default 668 664 1.01:1
PortalMinimalPerf.default 168 167 1.01:1
ReactionMinimalPerf.default 421 418 1.01:1
TextAreaMinimalPerf.default 551 547 1.01:1
TooltipMinimalPerf.default 2592 2557 1.01:1
AlertMinimalPerf.default 300 300 1:1
ButtonSlotsPerf.default 620 619 1:1
CarouselMinimalPerf.default 503 502 1:1
ChatMinimalPerf.default 796 798 1:1
CheckboxMinimalPerf.default 2302 2293 1:1
DatepickerMinimalPerf.default 6314 6327 1:1
DropdownMinimalPerf.default 2815 2824 1:1
EmbedMinimalPerf.default 4044 4050 1:1
SplitButtonMinimalPerf.default 4801 4798 1:1
AnimationMinimalPerf.default 553 561 0.99:1
DialogMinimalPerf.default 820 825 0.99:1
FlexMinimalPerf.default 295 298 0.99:1
ItemLayoutMinimalPerf.default 1296 1311 0.99:1
CustomToolbarPrototype.default 2759 2800 0.99:1
CardMinimalPerf.default 616 627 0.98:1
ImageMinimalPerf.default 437 448 0.98:1
InputMinimalPerf.default 1227 1258 0.98:1
ProviderMinimalPerf.default 415 422 0.98:1
SliderMinimalPerf.default 1747 1830 0.95:1
AvatarMinimalPerf.default 199 211 0.94:1
LoaderMinimalPerf.default 367 389 0.94:1
VideoMinimalPerf.default 781 827 0.94:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1185 1168 5000
Breadcrumb mount 2934 2948 1000
Checkbox mount 2620 2650 5000
CheckboxBase mount 2408 2344 5000
ChoiceGroup mount 4421 4413 5000
ComboBox mount 1232 1293 1000
CommandBar mount 9548 9578 1000
ContextualMenu mount 11011 11103 1000
DefaultButton mount 1358 1367 5000
DetailsRow mount 3580 3639 5000
DetailsRowFast mount 3615 3600 5000
DetailsRowNoStyles mount 3447 3462 5000
Dialog mount 3023 3103 1000
DocumentCardTitle mount 574 565 1000
Dropdown mount 3208 3191 5000
FocusTrapZone mount 1980 1992 5000
FocusZone mount 1973 1967 5000
GroupedList mount 1923 2128 2
GroupedList virtual-rerender 1153 1126 2
GroupedList virtual-rerender-with-unmount 1659 1689 2
GroupedListV2 mount 569 574 2
GroupedListV2 virtual-rerender 548 548 2
GroupedListV2 virtual-rerender-with-unmount 559 581 2
IconButton mount 1895 1891 5000
Label mount 723 736 5000
Layer mount 4291 4318 5000
Link mount 828 824 5000
MenuButton mount 1676 1657 5000
MessageBar mount 2304 2320 5000
Nav mount 3232 3514 1000
OverflowSet mount 1357 1369 5000
Panel mount 2512 2547 1000
Persona mount 1287 1266 1000
Pivot mount 1630 1650 1000
PrimaryButton mount 1513 1549 5000
Rating mount 6910 6924 5000
SearchBox mount 1524 1500 5000
Shimmer mount 2860 2852 5000
Slider mount 2082 2110 5000
SpinButton mount 4674 4644 5000
Spinner mount 801 793 5000
SplitButton mount 3059 3054 5000
Stack mount 841 842 5000
StackWithIntrinsicChildren mount 2461 2450 5000
StackWithTextChildren mount 4867 4884 5000
SwatchColorPicker mount 10620 10538 5000
TagPicker mount 2639 2595 5000
TeachingBubble mount 91615 89906 5000
Text mount 809 789 5000
TextField mount 1570 1587 5000
ThemeProvider mount 1514 1512 5000
ThemeProvider virtual-rerender 1101 1070 5000
ThemeProvider virtual-rerender-with-unmount 2164 2159 5000
Toggle mount 1104 1096 5000
buttonNative mount 555 540 5000

@Hotell Hotell merged commit e43b95f into microsoft:master Nov 15, 2022
@Hotell Hotell deleted the hotell/build/api-generation/fix-copy-compiled branch November 15, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants