Skip to content

chore: add both options to useArrowNavigationGroup #25568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chpalac merged 3 commits into from
Nov 8, 2022
Merged

chore: add both options to useArrowNavigationGroup #25568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b08107
chore: add both options to useArrowNavigationGroup
chpalac Nov 7, 2022
7281d2e
chore: add changes
chpalac Nov 7, 2022
c117e01
chore: update api
chpalac Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tabster-caace24f-01b0-4a75-b0c1-286a6698b7ae.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add both options to axis config",
"packageName": "@fluentui/react-tabster",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-tabster/etc/react-tabster.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const useArrowNavigationGroup: (options?: UseArrowNavigationGroupOptions)

// @public (undocumented)
export interface UseArrowNavigationGroupOptions {
axis?: 'vertical' | 'horizontal' | 'grid';
axis?: 'vertical' | 'horizontal' | 'grid' | 'both';
circular?: boolean;
ignoreDefaultKeydown?: Types.FocusableProps['ignoreKeydown'];
memorizeCurrent?: boolean;
Expand Down
4 changes: 3 additions & 1 deletion packages/react-components/react-tabster/src/hooks/useArrowNavigationGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface UseArrowNavigationGroupOptions {
* Focus will navigate vertically, horizontally or in both directions (grid), defaults to horizontally
* @defaultValue vertical
*/
axis?: 'vertical' | 'horizontal' | 'grid';
axis?: 'vertical' | 'horizontal' | 'grid' | 'both';
/**
* Focus will cycle to the first/last elements of the group without stopping
*/
Expand Down Expand Up @@ -60,6 +60,8 @@ function axisToMoverDirection(axis: UseArrowNavigationGroupOptions['axis']): Typ
return Types.MoverDirections.Horizontal;
case 'grid':
return Types.MoverDirections.Grid;
case 'both':
return Types.MoverDirections.Both;

case 'vertical':
default:
Expand Down