Skip to content

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 6 commits into from
Nov 8, 2022
Merged

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea7b5ed
expanding index.
dzearing Nov 5, 2022
15bd923
change.
dzearing Nov 5, 2022
1ddc428
Replacing with inline deprecation exclusions.
dzearing Nov 7, 2022
5aa9893
setting export * to warning.
dzearing Nov 7, 2022
1d1fc6c
change.
dzearing Nov 7, 2022
4474f53
moving rules around.
dzearing Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-10ceb504-58ea-4967-b2d3-daae2d632740.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "This change removes top-level export * from the index.js of @fluentui/react, which was implicitly exporting duplicates of symbols. Changing to explicit exports means that the export * as the top level barrel file can't introduce duplicate names. This works around an issue identified in esbuild: https://github.com/evanw/esbuild/issues/2658",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Loading