Skip to content

chore(react-portal, portal-compat, portal-compat-context): migrate to new package structure #25481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristanWatanabe merged 6 commits into from
Nov 2, 2022
Merged

chore(react-portal, portal-compat, portal-compat-context): migrate to new package structure #25481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ba6a2e
chore(react-portal): run migration generator
TristanWatanabe Nov 2, 2022
ef737d2
chore(react-portal-compat): run migration generator
TristanWatanabe Nov 2, 2022
f0625f3
chore(react-portal-compat-context): run migration generator
TristanWatanabe Nov 2, 2022
243cd48
Change Files
TristanWatanabe Nov 2, 2022
6cf9d96
fix(react-portal-compat): fix lint error
TristanWatanabe Nov 2, 2022
5449490
nit: dont include /testing in tsconfig glob
TristanWatanabe Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-portal-54fcbe1c-d23f-48f6-916a-9752737af543.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "chore: Migrate to new package structure.",
"packageName": "@fluentui/react-portal",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-portal-compat-0f43f3ad-6a47-4dec-8dfc-209831dd34b5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: Migrate to new package structure.",
"packageName": "@fluentui/react-portal-compat",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-portal-compat-context-a9e06321-41d0-43bb-b673-d1da46746c8a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "chore: Migrate to new package structure.",
"packageName": "@fluentui/react-portal-compat-context",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions packages/react-components/react-portal-compat-context/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
bundle-size/
config/
coverage/
e2e/
docs/
etc/
node_modules/
src/
stories/
dist/types/
temp/
__fixtures__
Expand All @@ -16,7 +17,7 @@ __tests__
*.api.json
*.log
*.spec.*
*.stories.*
*.cy.*
*.test.*
*.yml

Expand Down
0 ...nents/react-portal-compat-context/Spec.md → .../react-portal-compat-context/docs/Spec.md
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions packages/react-components/react-portal-compat/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
bundle-size/
config/
coverage/
e2e/
docs/
etc/
node_modules/
src/
stories/
dist/types/
temp/
__fixtures__
Expand All @@ -16,7 +17,7 @@ __tests__
*.api.json
*.log
*.spec.*
*.stories.*
*.cy.*
*.test.*
*.yml

Expand Down
4 changes: 2 additions & 2 deletions ...ct-portal-compat/e2e/PortalCompat.e2e.tsx → ...act-portal-compat/src/PortalCompat.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import { mount as mountBase } from '@cypress/react';
import { FluentProvider } from '@fluentui/react-provider';
import { teamsLightTheme } from '@fluentui/react-theme';
import { PortalCompatProvider } from '../src';
import { PortalCompatProvider } from '@fluentui/react-portal-compat';
import { usePortalCompat } from '@fluentui/react-portal-compat-context';

const mount = (element: JSX.Element) => {
Expand All @@ -21,7 +21,7 @@ describe('PortalCompat', () => {
if (ref.current) {
return registerPortal(ref.current);
}
}, []);
}, [registerPortal]);
Copy link
Member Author

@TristanWatanabe TristanWatanabe Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes lint error:

React Hook React.useEffect has a missing dependency: 'registerPortal'. Either include it or remove the dependency array  react-hooks/exhaustive-deps


return (
<div ref={ref}>
Expand Down
4 changes: 2 additions & 2 deletions ...nts/react-portal-compat/e2e/tsconfig.json → ...ents/react-portal-compat/tsconfig.cy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "../tsconfig.json",
"extends": "./tsconfig.json",
"compilerOptions": {
"isolatedModules": false,
"types": ["node", "cypress", "cypress-storybook/cypress", "cypress-real-events"],
"lib": ["ES2019", "dom"]
},
"include": ["**/*.ts", "**/*.tsx"]
"include": ["**/*.cy.ts", "**/*.cy.tsx"]
}
3 changes: 3 additions & 0 deletions packages/react-components/react-portal-compat/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
{
"path": "./tsconfig.spec.json"
},
{
"path": "./tsconfig.cy.json"
}
]
}
2 changes: 1 addition & 1 deletion packages/react-components/react-portal-compat/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx"],
"exclude": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx", "**/*.cy.ts", "**/*.cy.tsx"],
"include": ["./src/**/*.ts", "./src/**/*.tsx"]
}
5 changes: 3 additions & 2 deletions packages/react-components/react-portal/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
bundle-size/
config/
coverage/
e2e/
docs/
etc/
node_modules/
src/
stories/
dist/types/
temp/
__fixtures__
Expand All @@ -16,7 +17,7 @@ __tests__
*.api.json
*.log
*.spec.*
*.stories.*
*.cy.*
*.test.*
*.yml

Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-portal/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const rootMain = require('../../../../.storybook/main');

module.exports = /** @type {Omit<import('../../../../.storybook/main'), 'typescript'|'babel'>} */ ({
...rootMain,
stories: [...rootMain.stories, '../src/**/*.stories.mdx', '../src/**/index.stories.@(ts|tsx)'],
stories: [...rootMain.stories, '../stories/**/*.stories.mdx', '../stories/**/index.stories.@(ts|tsx)'],
addons: [...rootMain.addons],
webpackFinal: (config, options) => {
const localConfig = { ...rootMain.webpackFinal(config, options) };
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-portal/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
"checkJs": true,
"types": ["static-assets", "environment", "storybook__addons"]
},
"include": ["../src/**/*.stories.ts", "../src/**/*.stories.tsx", "*.js"]
"include": ["../stories/**/*.stories.ts", "../stories/**/*.stories.tsx", "*.js"]
}
0 ...ges/react-components/react-portal/Spec.md → ...eact-components/react-portal/docs/Spec.md
View file
Open in desktop
File renamed without changes.
0 .../stories/Portal/PortalDefault.stories.tsx → .../stories/Portal/PortalDefault.stories.tsx
View file
Open in desktop
File renamed without changes.
0 ...l/src/stories/Portal/PortalDescription.md → ...ortal/stories/Portal/PortalDescription.md
View file
Open in desktop
File renamed without changes.
0 ...rtal/src/stories/Portal/index.stories.tsx → ...t-portal/stories/Portal/index.stories.tsx
View file
Open in desktop
File renamed without changes.