Skip to content

Sankey revisit ankit #25455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankityadav4 merged 23 commits into from
Feb 6, 2023
Merged

Sankey revisit ankit #25455

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6aa878c
Sankey chart changes for the new design
ankityadav4 Sep 30, 2022
7529b16
Sankey changes for updated design
ankityadav4 Oct 31, 2022
a00f600
Adding change file
ankityadav4 Oct 31, 2022
1ceea77
Fixing build failure
ankityadav4 Nov 1, 2022
7436cb1
Fixing build failure
ankityadav4 Nov 1, 2022
c29f10c
fixing build failure
ankityadav4 Nov 1, 2022
792d6f0
fixing build failure
ankityadav4 Nov 1, 2022
8b7321b
fixing build failure
ankityadav4 Nov 1, 2022
f0513a3
Adding border color and reverting changes for package.json
ankityadav4 Nov 2, 2022
f394b7b
Adding changes for opacity changes for links,font size for text,diffe…
ankityadav4 Nov 14, 2022
be038e4
Resolving review comments and removing the examples used for testing
ankityadav4 Nov 23, 2022
0107a6b
Fixing the gradient issue
ankityadav4 Nov 24, 2022
c403724
Fixing the id issues
ankityadav4 Nov 24, 2022
250c852
Fixing the tooltip position issue
ankityadav4 Nov 24, 2022
c9862c6
Fixing the tooltip position issue
ankityadav4 Nov 24, 2022
4e9f39c
Adding comment for tooltip fix
ankityadav4 Nov 24, 2022
574b984
Fixing the tooltip position issue
ankityadav4 Nov 24, 2022
0c2214b
Fixing the tooltip position issue
ankityadav4 Nov 24, 2022
d03f6df
Incorporating review comments and improving code efficiency followimg…
ankityadav4 Dec 18, 2022
522ff90
Adding Unit Test cases for Sankey Chart
ankityadav4 Dec 28, 2022
254ab3d
Resolving review comments
ankityadav4 Jan 17, 2023
ec845ef
Minor fixes
ankityadav4 Jan 17, 2023
ee1e123
Resolving review comments
ankityadav4 Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-cfa801e0-6573-413b-bb65-4c94f5e8ddbe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Sankey chart changes for the new design",
"packageName": "@fluentui/react-charting",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/react-charting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@types/d3-sankey": "^0.11.0",
"@types/d3-scale": "^4.0.0",
"@types/d3-selection": "1.4.1",
"@types/d3-shape": "^1.2.3",
"@types/d3-shape": "2.1.0",
"@types/d3-time-format": "^2.1.0",
"@types/d3-time": "^1.1.0",
"@fluentui/set-version": "^8.2.2",
Expand All @@ -54,7 +54,7 @@
"d3-sankey": "^0.12.3",
"d3-scale": "^4.0.0",
"d3-selection": "1.3.0",
"d3-shape": "^1.2.0",
"d3-shape": "2.1.0",
"d3-time-format": "^2.1.3",
"d3-time": "^1.1.0",
"tslib": "^2.1.0"
Expand Down
Loading