Skip to content

Remove Web Components v2 implementation in v3 branch #25434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miroslavstastny merged 5 commits into from
Nov 7, 2022
Merged

Remove Web Components v2 implementation in v3 branch #25434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5d12f4
Delete existing Web Components implementation
miroslavstastny Oct 28, 2022
82ea1e9
Reset storybook
miroslavstastny Oct 28, 2022
0413af7
Change file
miroslavstastny Oct 28, 2022
b426ad7
Add empty test to pass CI
miroslavstastny Nov 4, 2022
8e548cc
Comment out WCs in stress-test
miroslavstastny Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
30 changes: 15 additions & 15 deletions apps/stress-test/src/pages/wc/simple-stress/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {
fluentButton,
fluentDivider,
fluentCheckbox,
fluentProgressRing,
fluentNumberField,
provideFluentDesignSystem,
} from '@fluentui/web-components';
// import {
// fluentButton,
// fluentDivider,
// fluentCheckbox,
// fluentProgressRing,
// fluentNumberField,
// provideFluentDesignSystem,
// } from '@fluentui/web-components';
import { StressApp } from '../../../components/wc/stressApp';
import { StressComponent } from '../../../components/wc/stressComponent';
import { StressContainer } from '../../../components/wc/stressContainer';
Expand All @@ -15,13 +15,13 @@ const testOptions = getTestOptions();

document.querySelector('stress-app')?.setAttribute('numchildren', testOptions.numStartNodes.toString());

provideFluentDesignSystem().register(
fluentButton(),
fluentDivider(),
fluentCheckbox(),
fluentProgressRing(),
fluentNumberField(),
);
// provideFluentDesignSystem().register(
// fluentButton(),
// fluentDivider(),
// fluentCheckbox(),
// fluentProgressRing(),
// fluentNumberField(),
// );

typeof StressApp;
typeof StressComponent;
Expand Down
4 changes: 2 additions & 2 deletions apps/stress-test/src/renderers/wc/button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { fluentButton, provideFluentDesignSystem } from '@fluentui/web-components';
// import { fluentButton, provideFluentDesignSystem } from '@fluentui/web-components';
import { DOMSelectorTreeComponentRenderer } from '../../shared/vanilla/types';

provideFluentDesignSystem().register(fluentButton());
// provideFluentDesignSystem().register(fluentButton());

const componentRenderer: DOMSelectorTreeComponentRenderer = (node, depth, index) => {
const btn = document.createElement('fluent-button') as HTMLElement;
Expand Down
4 changes: 2 additions & 2 deletions apps/stress-test/src/renderers/wc/checkbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { fluentCheckbox, provideFluentDesignSystem } from '@fluentui/web-components';
// import { fluentCheckbox, provideFluentDesignSystem } from '@fluentui/web-components';
import { DOMSelectorTreeComponentRenderer } from '../../shared/vanilla/types';

provideFluentDesignSystem().register(fluentCheckbox());
// provideFluentDesignSystem().register(fluentCheckbox());

const componentRenderer: DOMSelectorTreeComponentRenderer = (node, depth, index) => {
const checkbox = document.createElement('fluent-checkbox') as HTMLInputElement;
Expand Down
8 changes: 5 additions & 3 deletions apps/stress-test/src/renderers/wc/numberField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { fluentNumberField, NumberField, provideFluentDesignSystem } from '@fluentui/web-components';
// import { fluentNumberField, NumberField, provideFluentDesignSystem } from '@fluentui/web-components';
import { DOMSelectorTreeComponentRenderer } from '../../shared/vanilla/types';

provideFluentDesignSystem().register(fluentNumberField());
// provideFluentDesignSystem().register(fluentNumberField());

const componentRenderer: DOMSelectorTreeComponentRenderer = (node, depth, index) => {
const numberField = document.createElement('fluent-number-field') as NumberField;
const numberField = document.createElement('fluent-number-field') as HTMLElement & {
value: string;
}; /* as NumberField*/
numberField.value = node.value.name + ' ' + index;

return numberField;
Expand Down
5 changes: 3 additions & 2 deletions apps/stress-test/src/renderers/wc/textField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { fluentTextField, provideFluentDesignSystem } from '@fluentui/web-components';
// import { fluentTextField, provideFluentDesignSystem } from '@fluentui/web-components';
import { DOMSelectorTreeComponentRenderer } from '../../shared/vanilla/types';

provideFluentDesignSystem().register(fluentTextField());
// DO NOT MERGE TO MASTER - WC is not yet implemented in the branch
// provideFluentDesignSystem().register(fluentTextField());

const componentRenderer: DOMSelectorTreeComponentRenderer = (node, depth, index) => {
const field = document.createElement('fluent-text-field') as HTMLInputElement;
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-a9829849-1747-4588-aadf-da70207d0cf0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
Copy link
Member Author

@miroslavstastny miroslavstastny Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change intentionally marked as none, we do not want to release yet!

"comment": "Reset web-components for v3 development",
"packageName": "@fluentui/web-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
12 changes: 0 additions & 12 deletions packages/web-components/.storybook/preview-body.html
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/web-components/.storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
import { addons } from '@storybook/addons';
import { DOCS_RENDERED } from '@storybook/core-events';
import * as Fluent from '../src/index-rollup';
import { fillColor, neutralLayer1, neutralLayer2 } from '../src/design-tokens';
import webcomponentsTheme from './theme';
import { toggleBgMode, toggleLtr } from '../public/switches';

Fluent;

document.getElementById('luminance-switch').addEventListener('change', toggleBgMode, false);
document.getElementById('direction-switch').addEventListener('change', toggleLtr, false);

export const parameters = {
layout: 'fullscreen',
controls: { expanded: true },
Expand Down
Loading