Skip to content

fix(react-tabster): make acceptCondition optional as Tabster dont require it #25416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcosmoura merged 2 commits into from
Oct 27, 2022
Merged

fix(react-tabster): make acceptCondition optional as Tabster dont require it #25416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aa44dd
fix(react-tabster): make acceptCondition optional as Tabster dont req…
marcosmoura Oct 27, 2022
f8cfad8
fix(react-tabster): add missing change file
marcosmoura Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tabster-59ed64de-6eec-46c5-b0d6-2cd22cba4d0c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "make allowCondition a optional parameter for findAllFocusable function",
"packageName": "@fluentui/react-tabster",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-tabster/etc/react-tabster.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export interface UseFocusableGroupOptions {

// @public
export const useFocusFinders: () => {
findAllFocusable: (container: HTMLElement, acceptCondition: (el: HTMLElement) => boolean) => HTMLElement[];
findAllFocusable: (container: HTMLElement, acceptCondition?: ((el: HTMLElement) => boolean) | undefined) => HTMLElement[];
findFirstFocusable: (container: HTMLElement) => HTMLElement | null | undefined;
findLastFocusable: (container: HTMLElement) => HTMLElement | null | undefined;
findNextFocusable: (currentElement: HTMLElement, options?: Pick<Types.FindNextProps, 'container'>) => HTMLElement | null | undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-tabster/src/hooks/useFocusFinders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const useFocusFinders = () => {

// Narrow props for now and let need dictate additional props in the future
const findAllFocusable = React.useCallback(
(container: HTMLElement, acceptCondition: (el: HTMLElement) => boolean) =>
(container: HTMLElement, acceptCondition?: (el: HTMLElement) => boolean) =>
tabster?.focusable.findAll({ container, acceptCondition }) || [],
[tabster],
);
Expand Down