Skip to content

fix(react-dialog): removes exposing of internal type FluentTriggerComponent #25408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Oct 28, 2022
Merged

fix(react-dialog): removes exposing of internal type FluentTriggerComponent #25408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-dialog-a27523cc-5d13-4fd5-ac46-23fc9218bc73.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "removes exposing of internal type FluentTriggerComponent",
"packageName": "@fluentui/react-dialog",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 1 addition & 2 deletions packages/react-components/react-dialog/etc/react-dialog.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { ARIAButtonResultProps } from '@fluentui/react-aria';
import { ARIAButtonType } from '@fluentui/react-aria';
import type { ComponentProps } from '@fluentui/react-utilities';
import type { ComponentState } from '@fluentui/react-utilities';
import type { FluentTriggerComponent } from '@fluentui/react-utilities';
import type { ForwardRefComponent } from '@fluentui/react-utilities';
import { JSXElementConstructor } from 'react';
import * as React_2 from 'react';
Expand Down Expand Up @@ -163,7 +162,7 @@ export type DialogTitleSlots = {
export type DialogTitleState = ComponentState<DialogTitleSlots>;

// @public
export const DialogTrigger: React_2.FC<DialogTriggerProps> & FluentTriggerComponent;
export const DialogTrigger: React_2.FC<DialogTriggerProps>;

// @public (undocumented)
export type DialogTriggerAction = 'open' | 'close';
Expand Down
5 changes: 3 additions & 2 deletions packages/react-components/react-dialog/src/components/DialogTrigger/DialogTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ import type { FluentTriggerComponent } from '@fluentui/react-utilities';
* to it's wrapped child, but it won't be able to alter the dialog `open` state anymore,
* in that case the user must provide a `controlled state`
*/
export const DialogTrigger: React.FC<DialogTriggerProps> & FluentTriggerComponent = props => {
export const DialogTrigger: React.FC<DialogTriggerProps> = props => {
const state = useDialogTrigger_unstable(props);

return renderDialogTrigger_unstable(state);
};

DialogTrigger.displayName = 'DialogTrigger';
DialogTrigger.isFluentTriggerComponent = true;
// type casting here is required to ensure internal type FluentTriggerComponent is not leaked
(DialogTrigger as FluentTriggerComponent).isFluentTriggerComponent = true;