Skip to content

fix: list even/odd off-by-one issue #25358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spmonahan merged 1 commit into from
Oct 24, 2022
Merged

fix: list even/odd off-by-one issue #25358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/react-examples/src/react/List/List.Scrolling.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import { createListItems, IExampleItem } from '@fluentui/example-data';
import { mergeStyleSets, getTheme, normalize } from '@fluentui/react/lib/Styling';
import { useConst } from '@fluentui/react-hooks';

const evenItemHeight = 25;
const oddItemHeight = 50;
const evenItemHeight = 50;
const oddItemHeight = 25;
const numberOfItemsOnPage = 10;
const theme = getTheme();
const dropdownOptions = [
Expand All @@ -26,14 +26,14 @@ const styles = mergeStyleSets({
border: '1px solid #CCC',
marginTop: 20,
selectors: {
'.ms-List-cell:nth-child(odd)': {
height: 50,
lineHeight: 50,
background: theme.palette.neutralLighter,
'.ms-List-cell .odd': {
height: oddItemHeight,
lineHeight: oddItemHeight,
},
'.ms-List-cell:nth-child(even)': {
height: 25,
lineHeight: 25,
'.ms-List-cell .even': {
height: evenItemHeight,
lineHeight: evenItemHeight,
background: theme.palette.neutralLighter,
},
},
},
Expand All @@ -52,7 +52,7 @@ const styles = mergeStyleSets({

const onRenderCell = (item: IExampleItem, index: number): JSX.Element => {
return (
<div data-is-focusable>
<div data-is-focusable className={index % 2 === 0 ? 'even' : 'odd'}>
<div className={styles.itemContent}>
{index} &nbsp; {item.name}
</div>
Expand Down