Skip to content

[DO NOT MERGE Testing Screener] chore(vr-tests-v9): Convert v9 VR stories to CSF #25345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TristanWatanabe wants to merge 82 commits into from
Closed

[DO NOT MERGE Testing Screener] chore(vr-tests-v9): Convert v9 VR stories to CSF #25345

TristanWatanabe wants to merge 82 commits into from

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Oct 21, 2022 •
edited
Loading

Depends on #25162 and #25108

Current Behavior

New Behavior

Related Issue(s)

Fixes #

@TristanWatanabe
Add utility functions to create RTL, HC, and DM component variants
aa7fb10
@TristanWatanabe
chore: convert Avatar to CSF
07da72a
@TristanWatanabe
fix: add default state decorator to preview.js and update getStoryVar…
eb0bb9d 
…iant to include passed in decorators
@TristanWatanabe
fix: remove unnecessary decorators parameter
fe1d98f
@TristanWatanabe
Merge branch 'master' into convert-VR-stories-v9-CSF
a46daf3
@TristanWatanabe
fix: AvatarGroup stories
c9480f8
@TristanWatanabe
add utility functions for CSF test creation
fd8c495
@TristanWatanabe
chore: convert Button stories to CSF
68f2c3c
@TristanWatanabe
chore: convert CompoundButton to CSF
a0723ca
@TristanWatanabe
fix: add fluentprovider decorator to all CSF stories
488e548
@TristanWatanabe
chore: convert ToggleButton to CSF
96be209
@TristanWatanabe
fix: update getStoryVariant to fallback to story.name
ddf6b0b
@TristanWatanabe
chore: convert MenuButton to CSF
232688a
@TristanWatanabe
fix: add space to story.name fallback in getStoryVariant
c8c311e
@TristanWatanabe
test: uncomment out hover snapshot for CompoundButtonDefault
45f614f
@TristanWatanabe
test: try to fix flaky hover tests
83bd1ab
@TristanWatanabe
Update Progress.types.ts
adfa17b
@TristanWatanabe
chore: convert AvatarGroup to CSF
e737468
@TristanWatanabe
implement withFluentVRTestVariants decorator
0157f8f
@TristanWatanabe
update test to include new decorator
d00208f
@TristanWatanabe
update typings
c797198
@TristanWatanabe
fix: typing and update API
bda9ea4
@TristanWatanabe
Add usage of decorator to README
dcfcde3
@TristanWatanabe
remove unneed peerDep
794bd7f
@TristanWatanabe
fix: typing
f306846
@TristanWatanabe
Update API
fb87708
@TristanWatanabe
revert additions to react-storybook package
7bf1873
@TristanWatanabe
delete withFluentVrTestVariants
ed168ee
@TristanWatanabe
remove withFluentVrTestVariant
d3765ac
@TristanWatanabe
feat: withFluentProvider now accepts fluentTheme and dir
1f26987
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 21, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b1bb9a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 21, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 176464a38a9b6210505d6950e8bd81df959427e0 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1297 1275 5000
Button mount 929 931 5000
FluentProvider mount 1466 1508 5000
FluentProviderWithTheme mount 578 588 10
FluentProviderWithTheme virtual-rerender 537 540 10
FluentProviderWithTheme virtual-rerender-with-unmount 571 580 10
MakeStyles mount 1958 1944 50000
SpinButton mount 2364 2329 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 127 123 1.03:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonSlotsPerf.default 450 432 1.04:1
ImageMinimalPerf.default 353 340 1.04:1
LoaderMinimalPerf.default 528 509 1.04:1
SliderMinimalPerf.default 1290 1237 1.04:1
DividerMinimalPerf.default 318 309 1.03:1
DropdownManyItemsPerf.default 538 521 1.03:1
FormMinimalPerf.default 328 319 1.03:1
SkeletonMinimalPerf.default 312 304 1.03:1
StatusMinimalPerf.default 611 594 1.03:1
IconMinimalPerf.default 577 558 1.03:1
VideoMinimalPerf.default 628 611 1.03:1
ChatWithPopoverPerf.default 311 306 1.02:1
CheckboxMinimalPerf.default 1542 1516 1.02:1
FlexMinimalPerf.default 253 247 1.02:1
ListMinimalPerf.default 461 451 1.02:1
ListNestedPerf.default 464 455 1.02:1
MenuMinimalPerf.default 736 721 1.02:1
ReactionMinimalPerf.default 334 328 1.02:1
CustomToolbarPrototype.default 2217 2183 1.02:1
AnimationMinimalPerf.default 472 468 1.01:1
AvatarMinimalPerf.default 155 153 1.01:1
CarouselMinimalPerf.default 354 349 1.01:1
ChatMinimalPerf.default 624 616 1.01:1
DialogMinimalPerf.default 695 690 1.01:1
DropdownMinimalPerf.default 2188 2173 1.01:1
HeaderMinimalPerf.default 313 310 1.01:1
HeaderSlotsPerf.default 681 672 1.01:1
RosterPerf.default 1712 1700 1.01:1
PortalMinimalPerf.default 135 134 1.01:1
TooltipMinimalPerf.default 1903 1884 1.01:1
TreeMinimalPerf.default 697 689 1.01:1
AttachmentSlotsPerf.default 878 875 1:1
ButtonOverridesMissPerf.default 1025 1021 1:1
DatepickerMinimalPerf.default 4665 4667 1:1
EmbedMinimalPerf.default 2642 2649 1:1
InputMinimalPerf.default 852 850 1:1
MenuButtonMinimalPerf.default 1358 1359 1:1
PopupMinimalPerf.default 548 548 1:1
SplitButtonMinimalPerf.default 3293 3308 1:1
TableManyItemsPerf.default 1593 1587 1:1
TextAreaMinimalPerf.default 406 406 1:1
ToolbarMinimalPerf.default 799 798 1:1
ButtonMinimalPerf.default 137 138 0.99:1
ChatDuplicateMessagesPerf.default 211 213 0.99:1
GridMinimalPerf.default 294 297 0.99:1
ItemLayoutMinimalPerf.default 959 968 0.99:1
ListCommonPerf.default 520 527 0.99:1
ListWith60ListItems.default 489 496 0.99:1
ProviderMergeThemesPerf.default 988 998 0.99:1
ProviderMinimalPerf.default 319 321 0.99:1
RefMinimalPerf.default 191 192 0.99:1
TextMinimalPerf.default 301 303 0.99:1
TreeWith60ListItems.default 135 136 0.99:1
BoxMinimalPerf.default 297 304 0.98:1
CardMinimalPerf.default 457 465 0.98:1
LabelMinimalPerf.default 331 337 0.98:1
LayoutMinimalPerf.default 313 320 0.98:1
RadioGroupMinimalPerf.default 394 401 0.98:1
AccordionMinimalPerf.default 120 124 0.97:1
SegmentMinimalPerf.default 299 307 0.97:1
TableMinimalPerf.default 351 365 0.96:1
AlertMinimalPerf.default 211 223 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 22, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1182 1184 5000
Breadcrumb mount 2757 2785 1000
Checkbox mount 2651 2631 5000
CheckboxBase mount 2359 2370 5000
ChoiceGroup mount 4279 4279 5000
ComboBox mount 1179 1166 1000
CommandBar mount 9254 9263 1000
ContextualMenu mount 10392 10077 1000
DefaultButton mount 1363 1352 5000
DetailsRow mount 3398 3349 5000
DetailsRowFast mount 3381 3401 5000
DetailsRowNoStyles mount 3227 3264 5000
Dialog mount 2940 2944 1000
DocumentCardTitle mount 578 587 1000
Dropdown mount 3153 3166 5000
FocusTrapZone mount 1946 1977 5000
FocusZone mount 1938 1950 5000
GroupedList mount 48456 54185 2
GroupedList virtual-rerender 23631 23242 2
GroupedList virtual-rerender-with-unmount 82058 86209 2
GroupedListV2 mount 559 571 2
GroupedListV2 virtual-rerender 536 535 2
GroupedListV2 virtual-rerender-with-unmount 557 551 2
IconButton mount 1789 1815 5000
Label mount 751 752 5000
Layer mount 4148 4130 5000
Link mount 861 862 5000
MenuButton mount 1624 1616 5000
MessageBar mount 2322 2372 5000
Nav mount 3065 3065 1000
OverflowSet mount 1405 1419 5000
Panel mount 2487 2480 1000
Persona mount 1249 1259 1000
Pivot mount 1512 1500 1000
PrimaryButton mount 1486 1482 5000
Rating mount 6996 6994 5000
SearchBox mount 1468 1486 5000
Shimmer mount 2891 2914 5000
Slider mount 2122 2089 5000
SpinButton mount 4317 4290 5000
Spinner mount 812 817 5000
SplitButton mount 2891 2874 5000
Stack mount 866 866 5000
StackWithIntrinsicChildren mount 2194 2195 5000
StackWithTextChildren mount 4873 4909 5000
SwatchColorPicker mount 9525 9500 5000
TagPicker mount 2341 2344 5000
TeachingBubble mount 74483 74777 5000
Text mount 815 813 5000
TextField mount 1568 1557 5000
ThemeProvider mount 1432 1456 5000
ThemeProvider virtual-rerender 1144 1138 5000
ThemeProvider virtual-rerender-with-unmount 2010 1991 5000
Toggle mount 1123 1148 5000
buttonNative mount 530 537 5000

@TristanWatanabe TristanWatanabe removed the request for review from sopranopillow October 26, 2022 21:17
@TristanWatanabe TristanWatanabe changed the title [DO NOT MERGE Testing Screener] chore(vr-tests-v9): Convert Avatar, Accordion, Button and Image to CSF [DO NOT MERGE Testing Screener] chore(vr-tests-v9): Convert v9 VR stories to CSF Oct 26, 2022
@TristanWatanabe TristanWatanabe removed request for a team November 2, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TristanWatanabe TristanWatanabe

Labels

None yet

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

3 participants

@TristanWatanabe @fabricteam @GeoffCoxMSFT