Skip to content

fix: Detailslist is still tabbable when isHeaderVisible=false #25342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 2 commits into from
Oct 24, 2022
Merged

fix: Detailslist is still tabbable when isHeaderVisible=false #25342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842f3d5
fix: DetailsList is still tabbable when header is not visible
smhigley Oct 21, 2022
b75ff17
Change file
smhigley Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-55edf27b-cadb-4057-98bd-3e097dc780aa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: DetailsList is still tabbable when header is not visible",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/react/src/components/DetailsList/DetailsList.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ const DetailsListInner: React.ComponentType<IDetailsListInnerProps> = (

const rowRole = role === defaultRole ? undefined : 'presentation';

// add tabindex="0" to first row if no header exists, to ensure the focuszone is in the tab order
const rowFocusZoneProps = isHeaderVisible || index > 0 ? {} : { tabIndex: 0 };

const rowProps: IDetailsRowProps = {
item: item,
itemIndex: index,
Expand Down Expand Up @@ -520,6 +523,7 @@ const DetailsListInner: React.ComponentType<IDetailsListInnerProps> = (
useFastIcons,
role: rowRole,
isGridRow: true,
focusZoneProps: rowFocusZoneProps,
};

if (!item) {
Expand Down
10 changes: 10 additions & 0 deletions packages/react/src/components/DetailsList/DetailsList.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,4 +1077,14 @@ describe('DetailsList', () => {
const groupNameId = checkbox.getAttribute('aria-labelledby')?.split(' ')[1];
expect(container.querySelector(`#${groupNameId} span`)!.textContent).toEqual('Group 0');
});

it('makes the first row tabbable if isHeaderVisible is false', () => {
const component = renderer.create(
<DetailsList items={mockData(5)} columns={mockData(5, true)} isHeaderVisible={false} />,
);

const firstRow = component.root.findAllByType(DetailsRow)[0];

expect(firstRow.props.focusZoneProps?.tabIndex).toEqual(0);
});
});