-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: enable @internal api stripping in all packages and fix export maps
#25319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Hotell
wants to merge
47
commits into
microsoft:master
from
Hotell:hotell/build/api-stripping-migration
Closed
feat: enable @internal api stripping in all packages and fix export maps
#25319
Hotell
wants to merge
47
commits into
microsoft:master
from
Hotell:hotell/build/api-stripping-migration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@internal api stripping in all packages and fix export maps
This was referenced Oct 20, 2022
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f8bd5808004b220aa15f9dd183c3013c16613426 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 138 | 124 | 1.11:1 |
| LoaderMinimalPerf.default | 272 | 248 | 1.1:1 |
| SkeletonMinimalPerf.default | 311 | 292 | 1.07:1 |
| TextMinimalPerf.default | 310 | 293 | 1.06:1 |
| BoxMinimalPerf.default | 309 | 294 | 1.05:1 |
| DropdownManyItemsPerf.default | 549 | 524 | 1.05:1 |
| HeaderMinimalPerf.default | 334 | 317 | 1.05:1 |
| ImageMinimalPerf.default | 350 | 332 | 1.05:1 |
| AvatarMinimalPerf.default | 168 | 161 | 1.04:1 |
| CarouselMinimalPerf.default | 352 | 337 | 1.04:1 |
| ReactionMinimalPerf.default | 341 | 327 | 1.04:1 |
| SegmentMinimalPerf.default | 308 | 296 | 1.04:1 |
| ChatMinimalPerf.default | 645 | 625 | 1.03:1 |
| FormMinimalPerf.default | 334 | 323 | 1.03:1 |
| IconMinimalPerf.default | 574 | 555 | 1.03:1 |
| ToolbarMinimalPerf.default | 802 | 782 | 1.03:1 |
| ButtonMinimalPerf.default | 135 | 133 | 1.02:1 |
| ChatWithPopoverPerf.default | 288 | 283 | 1.02:1 |
| ListNestedPerf.default | 466 | 457 | 1.02:1 |
| TableMinimalPerf.default | 358 | 352 | 1.02:1 |
| AttachmentSlotsPerf.default | 875 | 867 | 1.01:1 |
| DialogMinimalPerf.default | 689 | 683 | 1.01:1 |
| DividerMinimalPerf.default | 317 | 314 | 1.01:1 |
| DropdownMinimalPerf.default | 2173 | 2149 | 1.01:1 |
| InputMinimalPerf.default | 856 | 844 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 970 | 965 | 1.01:1 |
| RosterPerf.default | 1713 | 1692 | 1.01:1 |
| PopupMinimalPerf.default | 554 | 549 | 1.01:1 |
| PortalMinimalPerf.default | 139 | 137 | 1.01:1 |
| ProviderMergeThemesPerf.default | 996 | 983 | 1.01:1 |
| RadioGroupMinimalPerf.default | 392 | 387 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3301 | 3276 | 1.01:1 |
| TableManyItemsPerf.default | 1577 | 1556 | 1.01:1 |
| VideoMinimalPerf.default | 625 | 616 | 1.01:1 |
| AttachmentMinimalPerf.default | 123 | 123 | 1:1 |
| CardMinimalPerf.default | 468 | 469 | 1:1 |
| DatepickerMinimalPerf.default | 4634 | 4631 | 1:1 |
| EmbedMinimalPerf.default | 2643 | 2634 | 1:1 |
| FlexMinimalPerf.default | 246 | 245 | 1:1 |
| HeaderSlotsPerf.default | 674 | 674 | 1:1 |
| LabelMinimalPerf.default | 333 | 334 | 1:1 |
| ListMinimalPerf.default | 458 | 457 | 1:1 |
| MenuMinimalPerf.default | 740 | 739 | 1:1 |
| MenuButtonMinimalPerf.default | 1357 | 1352 | 1:1 |
| RefMinimalPerf.default | 187 | 187 | 1:1 |
| TooltipMinimalPerf.default | 1890 | 1886 | 1:1 |
| TreeMinimalPerf.default | 700 | 701 | 1:1 |
| AccordionMinimalPerf.default | 118 | 119 | 0.99:1 |
| AnimationMinimalPerf.default | 469 | 473 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1010 | 1020 | 0.99:1 |
| CheckboxMinimalPerf.default | 1523 | 1537 | 0.99:1 |
| SliderMinimalPerf.default | 1218 | 1230 | 0.99:1 |
| StatusMinimalPerf.default | 604 | 610 | 0.99:1 |
| TextAreaMinimalPerf.default | 403 | 407 | 0.99:1 |
| CustomToolbarPrototype.default | 2148 | 2174 | 0.99:1 |
| ListCommonPerf.default | 514 | 522 | 0.98:1 |
| ProviderMinimalPerf.default | 311 | 317 | 0.98:1 |
| ButtonSlotsPerf.default | 415 | 427 | 0.97:1 |
| ChatDuplicateMessagesPerf.default | 204 | 211 | 0.97:1 |
| LayoutMinimalPerf.default | 309 | 318 | 0.97:1 |
| AlertMinimalPerf.default | 211 | 220 | 0.96:1 |
| ListWith60ListItems.default | 485 | 506 | 0.96:1 |
| GridMinimalPerf.default | 289 | 303 | 0.95:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1089 | 1113 | 5000 | |
| Breadcrumb | mount | 2953 | 2843 | 1000 | |
| Checkbox | mount | 2499 | 2471 | 5000 | |
| CheckboxBase | mount | 2399 | 2234 | 5000 | |
| ChoiceGroup | mount | 4274 | 4330 | 5000 | |
| ComboBox | mount | 1243 | 1251 | 1000 | |
| CommandBar | mount | 8965 | 9404 | 1000 | |
| ContextualMenu | mount | 10870 | 10102 | 1000 | |
| DefaultButton | mount | 1312 | 1397 | 5000 | |
| DetailsRow | mount | 3569 | 3479 | 5000 | |
| DetailsRowFast | mount | 3557 | 3440 | 5000 | |
| DetailsRowNoStyles | mount | 3339 | 3325 | 5000 | |
| Dialog | mount | 3115 | 3125 | 1000 | |
| DocumentCardTitle | mount | 569 | 533 | 1000 | |
| Dropdown | mount | 3219 | 3147 | 5000 | |
| FocusTrapZone | mount | 1992 | 1782 | 5000 | |
| FocusZone | mount | 1980 | 1769 | 5000 | |
| GroupedList | mount | 1790 | 2155 | 2 | |
| GroupedList | virtual-rerender | 1042 | 1073 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1587 | 1571 | 2 | |
| GroupedListV2 | mount | 563 | 546 | 2 | |
| GroupedListV2 | virtual-rerender | 521 | 550 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 540 | 548 | 2 | |
| IconButton | mount | 1905 | 1800 | 5000 | |
| Label | mount | 698 | 720 | 5000 | |
| Layer | mount | 4079 | 3921 | 5000 | |
| Link | mount | 763 | 763 | 5000 | |
| MenuButton | mount | 1662 | 1592 | 5000 | |
| MessageBar | mount | 2227 | 2111 | 5000 | |
| Nav | mount | 3096 | 3127 | 1000 | |
| OverflowSet | mount | 1421 | 1215 | 5000 | |
| Panel | mount | 2527 | 2526 | 1000 | |
| Persona | mount | 1149 | 1205 | 1000 | |
| Pivot | mount | 1458 | 1556 | 1000 | |
| PrimaryButton | mount | 1489 | 1469 | 5000 | |
| Rating | mount | 6463 | 6462 | 5000 | |
| SearchBox | mount | 1458 | 1378 | 5000 | |
| Shimmer | mount | 2852 | 2625 | 5000 | |
| Slider | mount | 2099 | 1942 | 5000 | |
| SpinButton | mount | 4522 | 4499 | 5000 | |
| Spinner | mount | 705 | 757 | 5000 | |
| SplitButton | mount | 2768 | 2906 | 5000 | |
| Stack | mount | 754 | 811 | 5000 | |
| StackWithIntrinsicChildren | mount | 2236 | 2446 | 5000 | |
| StackWithTextChildren | mount | 4379 | 4533 | 5000 | |
| SwatchColorPicker | mount | 10037 | 9943 | 5000 | |
| TagPicker | mount | 2714 | 2294 | 5000 | |
| TeachingBubble | mount | 83049 | 86087 | 5000 | |
| Text | mount | 772 | 775 | 5000 | |
| TextField | mount | 1392 | 1451 | 5000 | |
| ThemeProvider | mount | 1468 | 1494 | 5000 | |
| ThemeProvider | virtual-rerender | 966 | 1024 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1984 | 2055 | 5000 | |
| Toggle | mount | 1038 | 1050 | 5000 | |
| buttonNative | mount | 555 | 527 | 5000 |
e81e50d to
eb113e2
Compare
c88bbb5 to
fb80099
Compare
fb80099 to
f065b5a
Compare
This was referenced Oct 27, 2022
Contributor
|
Here's a follow up: @fluentui/react-aria #25403
@fluentui/react-positioning #25407
@fluentui/react-utilities #25406
@fluentui/react-shared-context #25405
@fluentui/react-context-selector #25404
@fluentui/react-dialog #25408
@fluentui/react-tooltip #25409
@fluentui/react-menu #25410
@fluentui/react-popover #25411
|
7f99859 to
d2f1ed1
Compare
… leaks and api-generation errors
- fix(bundle-size): fix type errors exposed by node 14 typings - fix(tools): fix type errors exposed by node 14 typings - fix(typings): fix type errors exposed by node 14 typings - fix(scripts): fix type errors exposed by node 14 typings
dca2cb4 to
2781dbd
Compare
Contributor
Author
|
This will be replaced by #25575 and followups |
1 task
Contributor
Author
|
Replaced by #25575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre - requirements (merged PRs):
Current Behavior
@internalare being shipped to customers (TS types)New Behavior
@internalare not being shipped to customers (TS types)Internal Tooling Breaking Changes
api.mdlocally:Before:
yarn workspace <project-name> build:localAfter:
yarn workspace <project-name> generate-apiRelated Issue(s)
🚨 Blockers / internal api leaks
After migration and internal api striping tooling activation, following issues were exposed
Action needed:
How to fix those (multiple options):
@internalannotations from APIs that are causing the failures (not ideal as it defeats the purpose)Summary of internal API (tokens) leaking grouped by package
@fluentui/react-aria
ARIAButtonAlteredPropsARIAButtonElement@fluentui/react-positioning
usePositioningMouseTarget@fluentui/react-utilities
useIsomorphicLayoutEffectuseMergedRefsFluentTriggerComponentTriggerProps@fluentui/react-shared-context
useThemeClassName_unstableuseTooltipVisibility_unstableTooltipVisibilityContextValue_unstableThemeContextValue_unstable@fluentui/react-context-selector
ContextSelectorDetailed API violations per affected package
@fluentui/react-components
@fluentui/react-provider
@fluentui/react-aria
@fluentui/react-radio
@fluentui/react-accordion
@fluentui/react-tooltip
@fluentui/react-popover
@fluentui/react-dialog
@fluentui/react-menu
@fluentui/react-avatar